[telepathy-glib/master] Look for qualified properties in immutable a{sv}

Will Thompson will.thompson at collabora.co.uk
Wed Jul 22 04:56:28 PDT 2009


TpChannel was looking up "InitiatorHandle" where it should have been
looking up "org.freedesktop.Telepathy.Channel.InitiatorHandle". This
failed, and meant that TpChannel always called GetAll() on channels,
even if you used tp_channel_new_from_properties() in an attempt to avoid
this happening.
---
 telepathy-glib/channel.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/telepathy-glib/channel.c b/telepathy-glib/channel.c
index e9750b3..a853cb1 100644
--- a/telepathy-glib/channel.c
+++ b/telepathy-glib/channel.c
@@ -858,13 +858,14 @@ _tp_channel_get_properties (TpChannel *self)
     {
       gboolean valid;
 
-      tp_asv_get_uint32 (self->priv->channel_properties, "InitiatorHandle",
-          &valid);
+      tp_asv_get_uint32 (self->priv->channel_properties,
+          TP_IFACE_CHANNEL ".InitiatorHandle", &valid);
 
       if (!valid)
         goto missing;
 
-      tp_asv_get_boolean (self->priv->channel_properties, "Requested", &valid);
+      tp_asv_get_boolean (self->priv->channel_properties,
+          TP_IFACE_CHANNEL ".Requested", &valid);
 
       if (!valid)
         goto missing;
-- 
1.5.6.5




More information about the telepathy-commits mailing list