[telepathy-mission-control/master] McdAccount: note that our logic for the nickname is inconsistent

Simon McVittie simon.mcvittie at collabora.co.uk
Mon Jun 1 10:14:12 PDT 2009


If another client alters the nickname while we're offline, we'll overwrite
it, but if another client alters the nickname while we're online, we'll
accept their alteration. We should make our minds up.
---
 src/mcd-account.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/src/mcd-account.c b/src/mcd-account.c
index 3ff8549..13e6c73 100644
--- a/src/mcd-account.c
+++ b/src/mcd-account.c
@@ -2627,6 +2627,11 @@ mcd_account_connection_ready_cb (McdAccount *account,
     g_return_if_fail (MCD_IS_ACCOUNT (account));
     g_return_if_fail (connection == priv->connection);
 
+    /* FIXME: ideally, on protocols with server-stored nicknames, this should
+     * only be done if the local Nickname has been changed since last time we
+     * were online; Aliasing doesn't currently offer a way to tell whether
+     * this is such a protocol, though. */
+
     nickname = mcd_account_get_alias (account);
 
     if (nickname != NULL)
-- 
1.5.6.5




More information about the telepathy-commits mailing list