[telepathy-gabble/master] Clarify immediate StreamDirectionChanged comment

Will Thompson will.thompson at collabora.co.uk
Tue Jun 2 07:25:02 PDT 2009


Fixes: fd.o#20841

Reviewed-by: Simon McVittie <simon.mcvittie at collabora.co.uk>
---
 src/media-channel.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/media-channel.c b/src/media-channel.c
index 70c1c6c..f7b83d8 100644
--- a/src/media-channel.c
+++ b/src/media-channel.c
@@ -2531,8 +2531,10 @@ construct_stream (GabbleMediaChannel *chan,
   tp_svc_channel_type_streamed_media_emit_stream_added (
       chan, id, priv->session->peer, mtype);
 
-  /* Initial stream direction was changed before we had time to hook up
-   * signal handler, so we call the handler manually to pick it up. */
+  /* StreamAdded does not include the stream's direction and pending send
+   * information, so we call the notify::combined-direction handler in order to
+   * emit StreamDirectionChanged for the initial state.
+   */
   stream_direction_changed_cb (stream, NULL, chan);
 
   gabble_media_channel_hold_new_stream (chan, stream,
-- 
1.5.6.5



More information about the telepathy-commits mailing list