[telepathy-gabble/master] Don't require 'initiator' on Jingle stanzas

Will Thompson will.thompson at collabora.co.uk
Tue Jun 9 10:57:37 PDT 2009


My reading of <http://xmpp.org/extensions/xep-0166.html#def-jingle> is
that clients are at liberty to ignore the 'initiator' on
session-initiate, and just use the IQ's 'from', and should thereafter
ignore 'initiator' anyway.
---
 src/jingle-session.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/src/jingle-session.c b/src/jingle-session.c
index d66cb07..72c2874 100644
--- a/src/jingle-session.c
+++ b/src/jingle-session.c
@@ -1373,7 +1373,6 @@ gabble_jingle_session_parse (GabbleJingleSession *sess, JingleAction action, LmM
   GabbleJingleSessionPrivate *priv = sess->priv;
   LmMessageNode *iq_node, *session_node;
   const gchar *from;
-  const gchar *initiator;
 
   iq_node = lm_message_get_node (message);
 
@@ -1415,13 +1414,6 @@ gabble_jingle_session_parse (GabbleJingleSession *sess, JingleAction action, LmM
       return FALSE;
     }
 
-  initiator = lm_message_node_get_attribute (session_node, "initiator");
-  if (initiator == NULL)
-    {
-      SET_BAD_REQ ("session initiator not found");
-      return FALSE;
-    }
-
   contact_repo = tp_base_connection_get_handles (
       (TpBaseConnection *) priv->conn, TP_HANDLE_TYPE_CONTACT);
 
-- 
1.5.6.5




More information about the telepathy-commits mailing list