[telepathy-mission-control/master] Add a regression test for not creating a channel due to low memory
Simon McVittie
simon.mcvittie at collabora.co.uk
Wed Jun 24 05:00:40 PDT 2009
This test asserts that fd.o #21035 still exists, in order to verify
existing functionality.
---
test/twisted/Makefile.am | 1 +
test/twisted/dispatcher/create-lowmem.py | 188 ++++++++++++++++++++++++++++++
2 files changed, 189 insertions(+), 0 deletions(-)
create mode 100644 test/twisted/dispatcher/create-lowmem.py
diff --git a/test/twisted/Makefile.am b/test/twisted/Makefile.am
index 0542c59..e1339c9 100644
--- a/test/twisted/Makefile.am
+++ b/test/twisted/Makefile.am
@@ -22,6 +22,7 @@ TWISTED_BASIC_TESTS = \
dispatcher/cancel.py \
dispatcher/capture-bundle.py \
dispatcher/create-handler-fails.py \
+ dispatcher/create-lowmem.py \
dispatcher/create-no-preferred-handler.py \
dispatcher/create-text.py \
dispatcher/dispatch-activatable.py \
diff --git a/test/twisted/dispatcher/create-lowmem.py b/test/twisted/dispatcher/create-lowmem.py
new file mode 100644
index 0000000..ef7d2be
--- /dev/null
+++ b/test/twisted/dispatcher/create-lowmem.py
@@ -0,0 +1,188 @@
+"""Regression test for ChannelDispatcher rejecting channel creation due to
+low memory.
+"""
+
+import dbus
+import dbus.service
+
+from servicetest import EventPattern, tp_name_prefix, tp_path_prefix, \
+ call_async
+from mctest import exec_test, SimulatedConnection, SimulatedClient, \
+ create_fakecm_account, enable_fakecm_account, SimulatedChannel, \
+ expect_client_setup
+import constants as cs
+
+def test(q, bus, mc):
+ params = dbus.Dictionary({"account": "someguy at example.com",
+ "password": "secrecy"}, signature='sv')
+ cm_name_ref, account = create_fakecm_account(q, bus, mc, params)
+ conn = enable_fakecm_account(q, bus, mc, account, params)
+
+ text_fixed_properties = dbus.Dictionary({
+ cs.CHANNEL + '.TargetHandleType': cs.HT_CONTACT,
+ cs.CHANNEL + '.ChannelType': cs.CHANNEL_TYPE_TEXT,
+ }, signature='sv')
+
+ client = SimulatedClient(q, bus, 'Empathy',
+ observe=[text_fixed_properties], approve=[text_fixed_properties],
+ handle=[text_fixed_properties], bypass_approval=False)
+
+ # No Approver should be invoked at any point during this test, because the
+ # Channel was Requested
+ def fail_on_approval(e):
+ raise AssertionError('Approver should not be invoked')
+ q.add_dbus_method_impl(fail_on_approval, path=client.object_path,
+ interface=cs.APPROVER, method='AddDispatchOperation')
+
+ # wait for MC to download the properties
+ expect_client_setup(q, [client])
+
+ # This is normally a C API, only exposed to D-Bus here for testing
+ secret_debug_api = dbus.Interface(bus.get_object(cs.AM, "/"),
+ 'org.freedesktop.Telepathy.MissionControl5.RegressionTests')
+ MCD_SYSTEM_MEMORY_CONSERVED = 2
+
+ # Set the idle flag and fail to create a channel
+ secret_debug_api.ChangeSystemFlags(dbus.UInt32(MCD_SYSTEM_MEMORY_CONSERVED),
+ dbus.UInt32(0))
+ test_channel_creation(q, bus, account, client, conn, True)
+
+ # Unset the idle flag and create a channel
+ secret_debug_api.ChangeSystemFlags(dbus.UInt32(0),
+ dbus.UInt32(MCD_SYSTEM_MEMORY_CONSERVED))
+ test_channel_creation(q, bus, account, client, conn, False)
+
+def test_channel_creation(q, bus, account, client, conn, lowmem):
+ user_action_time = dbus.Int64(1238582606)
+
+ cd = bus.get_object(cs.CD, cs.CD_PATH)
+ cd_props = dbus.Interface(cd, cs.PROPERTIES_IFACE)
+
+ # chat UI calls ChannelDispatcher.CreateChannel
+ request = dbus.Dictionary({
+ cs.CHANNEL + '.ChannelType': cs.CHANNEL_TYPE_TEXT,
+ cs.CHANNEL + '.TargetHandleType': cs.HT_CONTACT,
+ cs.CHANNEL + '.TargetID': 'juliet',
+ }, signature='sv')
+ account_requests = dbus.Interface(account,
+ cs.ACCOUNT_IFACE_NOKIA_REQUESTS)
+ call_async(q, cd, 'CreateChannel',
+ account.object_path, request, user_action_time, client.bus_name,
+ dbus_interface=cs.CD)
+
+ if lowmem:
+ # FIXME: fd.o #21035: an undocumented error is raised at the wrong time
+ ret = q.expect('dbus-error',
+ method='CreateChannel')
+ assert ret.error.get_dbus_name() == 'com.nokia.MissionControl.Errors.Lowmem'
+ return
+
+ ret = q.expect('dbus-return',
+ method='CreateChannel')
+ request_path = ret.value[0]
+
+ # chat UI connects to signals and calls ChannelRequest.Proceed()
+
+ cr = bus.get_object(cs.AM, request_path)
+ request_props = cr.GetAll(cs.CR, dbus_interface=cs.PROPERTIES_IFACE)
+ assert request_props['Account'] == account.object_path
+ assert request_props['Requests'] == [request]
+ assert request_props['UserActionTime'] == user_action_time
+ assert request_props['PreferredHandler'] == client.bus_name
+ assert request_props['Interfaces'] == []
+
+ cr.Proceed(dbus_interface=cs.CR)
+
+ # FIXME: should the CreateChannel call, and the AddRequest
+ # call, be in a defined order? Probably not though, since CMs and Clients
+ # aren't meant to be the same process!
+
+ cm_request_call, add_request_call = q.expect_many(
+ EventPattern('dbus-method-call',
+ interface=cs.CONN_IFACE_REQUESTS,
+ method='CreateChannel',
+ path=conn.object_path, args=[request], handled=False),
+ EventPattern('dbus-method-call', handled=False,
+ interface=cs.CLIENT_IFACE_REQUESTS,
+ method='AddRequest', path=client.object_path),
+ )
+
+ assert add_request_call.args[0] == request_path
+ request_props = add_request_call.args[1]
+ assert request_props[cs.CR + '.Account'] == account.object_path
+ assert request_props[cs.CR + '.Requests'] == [request]
+ assert request_props[cs.CR + '.UserActionTime'] == user_action_time
+ # FIXME: this is not actually in telepathy-spec (although maybe it
+ # should be) - fd.o #21013
+ assert request_props[cs.CR + '.PreferredHandler'] == client.bus_name
+ assert request_props[cs.CR + '.Interfaces'] == []
+
+ q.dbus_return(add_request_call.message, signature='')
+
+ # Time passes. A channel is returned.
+
+ channel_immutable = dbus.Dictionary(request)
+ channel_immutable[cs.CHANNEL + '.InitiatorID'] = conn.self_ident
+ channel_immutable[cs.CHANNEL + '.InitiatorHandle'] = conn.self_handle
+ channel_immutable[cs.CHANNEL + '.Requested'] = True
+ channel_immutable[cs.CHANNEL + '.Interfaces'] = \
+ dbus.Array([], signature='s')
+ channel_immutable[cs.CHANNEL + '.TargetHandle'] = \
+ conn.ensure_handle(cs.HT_CONTACT, 'juliet')
+ channel = SimulatedChannel(conn, channel_immutable)
+
+ # this order of events is guaranteed by telepathy-spec (since 0.17.14)
+ q.dbus_return(cm_request_call.message,
+ channel.object_path, channel.immutable, signature='oa{sv}')
+ channel.announce()
+
+ # Observer should get told, processing waits for it
+ e = q.expect('dbus-method-call',
+ path=client.object_path,
+ interface=cs.OBSERVER, method='ObserveChannels',
+ handled=False)
+ assert e.args[0] == account.object_path, e.args
+ assert e.args[1] == conn.object_path, e.args
+ assert e.args[3] == '/', e.args # no dispatch operation
+ assert e.args[4] == [request_path], e.args
+ channels = e.args[2]
+ assert len(channels) == 1, channels
+ assert channels[0][0] == channel.object_path, channels
+ assert channels[0][1] == channel_immutable, channels
+
+ # Observer says "OK, go"
+ q.dbus_return(e.message, signature='')
+
+ # Handler is next
+ e = q.expect('dbus-method-call',
+ path=client.object_path,
+ interface=cs.HANDLER, method='HandleChannels',
+ handled=False)
+ assert e.args[0] == account.object_path, e.args
+ assert e.args[1] == conn.object_path, e.args
+ channels = e.args[2]
+ assert len(channels) == 1, channels
+ assert channels[0][0] == channel.object_path, channels
+ assert channels[0][1] == channel_immutable, channels
+ assert e.args[3] == [request_path], e.args
+ assert e.args[4] == user_action_time
+ assert isinstance(e.args[5], dict)
+ assert len(e.args) == 6
+
+ # Handler fails at handling channels
+ q.dbus_raise(e.message, cs.INVALID_ARGUMENT, 'Parlez vous Freezepop?')
+
+ e = q.expect('dbus-method-call', path=client.object_path,
+ interface=cs.CLIENT_IFACE_REQUESTS, method='RemoveRequest',
+ handled=False)
+ q.dbus_raise(e.message, cs.INVALID_ARGUMENT, 'Do you realise?')
+
+ q.expect_many(
+ EventPattern('dbus-signal', path=cr.object_path,
+ interface=cs.CR, signal='Failed'),
+ EventPattern('dbus-method-call', path=channel.object_path,
+ interface=cs.CHANNEL, method='Close', handled=True),
+ )
+
+if __name__ == '__main__':
+ exec_test(test, {})
--
1.5.6.5
More information about the telepathy-commits
mailing list