[telepathy-mission-control/master] _mcd_account_set_parameters: check validity before perhaps auto-connecting, rather than only doing so in UpdateParameters

Simon McVittie simon.mcvittie at collabora.co.uk
Thu Jun 25 06:28:09 PDT 2009


This means that when deciding whether to auto-connect, we already have the
updated value for whether the account is valid.
---
 src/mcd-account.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mcd-account.c b/src/mcd-account.c
index 0aa8706..e063442 100644
--- a/src/mcd-account.c
+++ b/src/mcd-account.c
@@ -1657,6 +1657,7 @@ _mcd_account_set_parameters (McdAccount *account, GHashTable *params,
     }
     g_slist_free (dbus_properties);
 
+    mcd_account_check_validity (account);
     _mcd_account_maybe_autoconnect (account);
     return TRUE;
 }
@@ -1694,7 +1695,6 @@ account_update_parameters (TpSvcAccount *self, GHashTable *set,
     mcd_account_changed_property (account, "Parameters", &value);
     g_value_unset (&value);
 
-    mcd_account_check_validity (account);
     mcd_account_manager_write_conf (priv->account_manager);
 
     g_ptr_array_add (not_yet, NULL);
-- 
1.5.6.5




More information about the telepathy-commits mailing list