[Telepathy-commits] [telepathy-haze/master] haze_connection_request_aliases: don't leak aliases array on invalid handles

Simon McVittie simon.mcvittie at collabora.co.uk
Mon Mar 23 02:44:06 PDT 2009


---
 src/connection-aliasing.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/connection-aliasing.c b/src/connection-aliasing.c
index b1b5295..059b2ed 100644
--- a/src/connection-aliasing.c
+++ b/src/connection-aliasing.c
@@ -109,7 +109,7 @@ haze_connection_request_aliases (TpSvcConnectionInterfaceAliasing *self,
         tp_base_connection_get_handles (base, TP_HANDLE_TYPE_CONTACT);
     guint i;
     GError *error = NULL;
-    const gchar **aliases = g_new0 (const gchar *, contacts->len + 1);
+    const gchar **aliases;
 
     if (!tp_handles_are_valid (contact_handles, contacts, FALSE, &error))
     {
@@ -118,6 +118,8 @@ haze_connection_request_aliases (TpSvcConnectionInterfaceAliasing *self,
         return;
     }
 
+    aliases = g_new0 (const gchar *, contacts->len + 1);
+
     for (i = 0; i < contacts->len; i++)
     {
         TpHandle handle = g_array_index (contacts, TpHandle, i);
-- 
1.5.6.5




More information about the telepathy-commits mailing list