[Telepathy-commits] [telepathy-qt4/master] StreamedMediaChannel: No need to check for Bidirectional on MediaStream::sending/receiving.

Andre Moreira Magalhaes (andrunko) andre.magalhaes at collabora.co.uk
Wed Mar 11 08:48:54 PDT 2009


Rationale:
<smcv> MediaStream::sending(), MediaStream::receiving() can safely assume that
MediaStreamDirection is a bitfield
<smcv> (it's an enum because of historical mistakes)
<smcv> Bidirectional is just (Send|Receive)
---
 TelepathyQt4/Client/streamed-media-channel.cpp |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/TelepathyQt4/Client/streamed-media-channel.cpp b/TelepathyQt4/Client/streamed-media-channel.cpp
index e552633..04209ce 100644
--- a/TelepathyQt4/Client/streamed-media-channel.cpp
+++ b/TelepathyQt4/Client/streamed-media-channel.cpp
@@ -266,8 +266,7 @@ Telepathy::MediaStreamType MediaStream::type() const
  */
 bool MediaStream::sending() const
 {
-    return (mPriv->direction & Telepathy::MediaStreamDirectionSend ||
-            mPriv->direction & Telepathy::MediaStreamDirectionBidirectional);
+    return mPriv->direction & Telepathy::MediaStreamDirectionSend;
 }
 
 /**
@@ -277,8 +276,7 @@ bool MediaStream::sending() const
  */
 bool MediaStream::receiving() const
 {
-    return (mPriv->direction & Telepathy::MediaStreamDirectionReceive ||
-            mPriv->direction & Telepathy::MediaStreamDirectionBidirectional);
+    return mPriv->direction & Telepathy::MediaStreamDirectionReceive;
 }
 
 /**
-- 
1.5.6.5




More information about the telepathy-commits mailing list