[telepathy-gabble/master] Don't expect unobservable MembersChanged signals.

Will Thompson will.thompson at collabora.co.uk
Tue Mar 31 09:56:31 PDT 2009


MembersChanged signals fired before RequestChannel has returned or
NewChannel[s] are emitted are not observable by well-behaved Telepathy
clients.

This has the side-effect of removing a
    q.expect('dbus-*')
    q.expect('stream-*')
race from this test.
---
 tests/twisted/muc/test-muc-properties.py |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/tests/twisted/muc/test-muc-properties.py b/tests/twisted/muc/test-muc-properties.py
index 85136bd..493cb55 100644
--- a/tests/twisted/muc/test-muc-properties.py
+++ b/tests/twisted/muc/test-muc-properties.py
@@ -55,19 +55,15 @@ def test(q, bus, conn, stream):
     call_async(q, conn, 'RequestChannel', constants.CHANNEL_TYPE_TEXT, 2,
         handles[0], True)
 
-    q.expect('dbus-signal', signal='MembersChanged',
-        args=[u'', [], [], [], [2], 0, 0])
     q.expect('stream-presence', to='chat at conf.localhost/test')
 
     # Send presence for own membership of room.
     stream.send(
         make_muc_presence('owner', 'moderator', 'chat at conf.localhost', 'test'))
 
-    iq, _, ret = q.expect_many(
+    iq, ret = q.expect_many(
         EventPattern('stream-iq', to='chat at conf.localhost', iq_type='get',
             query_ns=ns.MUC_OWNER),
-        EventPattern('dbus-signal', signal='MembersChanged',
-            args=[u'', [2], [], [], [], 0, 0]),
         EventPattern('dbus-return', method='RequestChannel'))
     handle_muc_get_iq(stream, iq.stanza)
 
-- 
1.5.6.5




More information about the telepathy-commits mailing list