[telepathy-mission-control/master] servicetest: require signature when emitting D-Bus messages

Simon McVittie simon.mcvittie at collabora.co.uk
Fri Mar 27 12:41:36 PDT 2009


Otherwise, it's very easy to get it wrong, which means that dbus-glib
will silently ignore the message. Thanks, dbus-glib.
---
 test/twisted/servicetest.py |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/test/twisted/servicetest.py b/test/twisted/servicetest.py
index 5d00d0b..2a32cb8 100644
--- a/test/twisted/servicetest.py
+++ b/test/twisted/servicetest.py
@@ -327,11 +327,13 @@ class IteratingEventQueue(BaseEventQueue):
                 (EventPattern('dbus-method-call', **kwargs), cb))
 
     def dbus_emit(self, path, iface, name, *a, **k):
+        assert 'signature' in k, k
         message = dbus.lowlevel.SignalMessage(path, iface, name)
         message.append(*a, **k)
         self._bus.send_message(message)
 
     def dbus_return(self, in_reply_to, *a, **k):
+        assert 'signature' in k, k
         reply = dbus.lowlevel.MethodReturnMessage(in_reply_to)
         reply.append(*a, **k)
         self._bus.send_message(reply)
-- 
1.5.6.5




More information about the telepathy-commits mailing list