[telepathy-qt4/master] ChannelRequest: Explain that the FIXME is actually a Qt bug.
Andre Moreira Magalhaes (andrunko)
andre.magalhaes at collabora.co.uk
Mon May 11 12:13:02 PDT 2009
---
TelepathyQt4/channel-request.cpp | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/TelepathyQt4/channel-request.cpp b/TelepathyQt4/channel-request.cpp
index da5f91a..af165af 100644
--- a/TelepathyQt4/channel-request.cpp
+++ b/TelepathyQt4/channel-request.cpp
@@ -130,8 +130,9 @@ void ChannelRequest::Private::introspectMain(ChannelRequest::Private *self)
new QDBusPendingCallWatcher(
self->properties->GetAll(TELEPATHY_INTERFACE_CHANNEL_REQUEST),
self->parent);
- // FIXME: check if we need to add this check in all other places, and if
- // not, why this is needed here.
+ // FIXME: This is a Qt bug fixed upstream, should be in the next Qt release.
+ // We should not need to check watcher->isFinished() here, remove the
+ // check when a fixed Qt version is released.
if (watcher->isFinished()) {
self->parent->gotMainProperties(watcher);
} else {
--
1.5.6.5
More information about the telepathy-commits
mailing list