[telepathy-qt4/master] Reference bug number on QDateTime 64-bit time_t usage.
Andre Moreira Magalhaes (andrunko)
andre.magalhaes at collabora.co.uk
Mon May 11 14:12:17 PDT 2009
---
TelepathyQt4/channel-request.cpp | 4 +---
TelepathyQt4/client-registrar.cpp | 4 +---
TelepathyQt4/message.cpp | 8 ++------
3 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/TelepathyQt4/channel-request.cpp b/TelepathyQt4/channel-request.cpp
index 2d31b34..705279b 100644
--- a/TelepathyQt4/channel-request.cpp
+++ b/TelepathyQt4/channel-request.cpp
@@ -158,9 +158,7 @@ void ChannelRequest::Private::extractMainProps(const QVariantMap &props)
SLOT(onAccountReady(Tp::PendingOperation *)));
}
- // FIXME: Telepathy supports 64-bit time_t, but Qt only does so on
- // ILP64 systems (e.g. sparc64, but not x86_64). If QDateTime
- // gains a fromTimestamp64 method, we should use it instead.
+ // FIXME See http://bugs.freedesktop.org/show_bug.cgi?id=21690
uint stamp = (uint) qdbus_cast<qlonglong>(props.value("UserActionTime"));
if (stamp != 0) {
userActionTime = QDateTime::fromTime_t(stamp);
diff --git a/TelepathyQt4/client-registrar.cpp b/TelepathyQt4/client-registrar.cpp
index 44cd6d7..5f9d248 100644
--- a/TelepathyQt4/client-registrar.cpp
+++ b/TelepathyQt4/client-registrar.cpp
@@ -108,9 +108,7 @@ void ClientHandlerAdaptor::HandleChannels(const QDBusObjectPath &accountPath,
channelRequests.append(channelRequest);
}
- // FIXME: Telepathy supports 64-bit time_t, but Qt only does so on
- // ILP64 systems (e.g. sparc64, but not x86_64). If QDateTime
- // gains a fromTimestamp64 method, we should use it instead.
+ // FIXME See http://bugs.freedesktop.org/show_bug.cgi?id=21690
QDateTime userActionTime;
if (userActionTime_t != 0) {
userActionTime = QDateTime::fromTime_t((uint) userActionTime_t);
diff --git a/TelepathyQt4/message.cpp b/TelepathyQt4/message.cpp
index d249cb5..ae7e8c7 100644
--- a/TelepathyQt4/message.cpp
+++ b/TelepathyQt4/message.cpp
@@ -223,9 +223,7 @@ Message::~Message()
*/
QDateTime Message::sent() const
{
- // FIXME: Telepathy supports 64-bit time_t, but Qt only does so on
- // ILP64 systems (e.g. sparc64, but not x86_64). If QDateTime
- // gains a fromTimestamp64 method, we should use it instead.
+ // FIXME See http://bugs.freedesktop.org/show_bug.cgi?id=21690
uint stamp = mPriv->value(0, "message-sent").toUInt();
if (stamp != 0) {
return QDateTime::fromTime_t(stamp);
@@ -485,9 +483,7 @@ ReceivedMessage::~ReceivedMessage()
*/
QDateTime ReceivedMessage::received() const
{
- // FIXME: Telepathy supports 64-bit time_t, but Qt only does so on
- // ILP64 systems (e.g. sparc64, but not x86_64). If QDateTime
- // gains a fromTimestamp64 method, we should use it instead.
+ // FIXME See http://bugs.freedesktop.org/show_bug.cgi?id=21690
uint stamp = mPriv->value(0, "message-received").toUInt();
if (stamp != 0) {
return QDateTime::fromTime_t(stamp);
--
1.5.6.5
More information about the telepathy-commits
mailing list