[telepathy-gabble/master] Forbid the right event when unholding

Will Thompson will.thompson at collabora.co.uk
Fri May 29 12:11:37 PDT 2009


The test was trying to check that Gabble doesn't send <unhold/> before
the streaming implementation has successfully reclaimed its resources,
but was actually checking that Gabble doesn't send <hold/> before then.
Whoops.
---
 tests/twisted/jingle/hold-audio.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/twisted/jingle/hold-audio.py b/tests/twisted/jingle/hold-audio.py
index 191e13c..2fb8217 100644
--- a/tests/twisted/jingle/hold-audio.py
+++ b/tests/twisted/jingle/hold-audio.py
@@ -86,7 +86,7 @@ def test(jp, q, bus, conn, stream):
 
     # ---- Test 4: successful unhold ----
 
-    q.forbid_events(hold_event)
+    q.forbid_events(unhold_event)
 
     call_async(q, chan.Hold, 'RequestHold', False)
     q.expect_many(
@@ -99,7 +99,7 @@ def test(jp, q, bus, conn, stream):
     # Ensure that if Gabble sent the <active/> stanza too early it's already
     # arrived.
     sync_stream(q, stream)
-    q.unforbid_events(hold_event)
+    q.unforbid_events(unhold_event)
 
     call_async(q, stream_handler, 'HoldState', False)
     q.expect_many(
-- 
1.5.6.5




More information about the telepathy-commits mailing list