[telepathy-mission-control/master] McdDispatchOperation: comment the fact that handle_with_time is global
Simon McVittie
simon.mcvittie at collabora.co.uk
Mon Nov 2 09:46:57 PST 2009
In an earlier version of the branch I separated it to be per Approval
and used the timestamp from the appropriate approval, but during review
Sjoerd considered this to be unnecessarily complicated; it's also
undesirable if several HandleWith calls are "compatible", e.g.
HandleWith("...Empathy") and HandleWith("").
---
src/mcd-dispatch-operation.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/mcd-dispatch-operation.c b/src/mcd-dispatch-operation.c
index 049fb53..0341d0a 100644
--- a/src/mcd-dispatch-operation.c
+++ b/src/mcd-dispatch-operation.c
@@ -178,6 +178,15 @@ struct _McdDispatchOperationPrivate
* this is NotYours, and on failure, it's something else */
GError *result;
+ /* The time of the latest call to HandleWith(), for focus-stealing
+ * prevention.
+ *
+ * This is shared between calls, so if the user makes contradictory
+ * choices, like HandleWith("...Empathy") and HandleWith("...Kopete") in
+ * quick succession, the channel will be handled with Empathy, but the
+ * timestamp for focus-stealing purposes will be that of the call that
+ * wanted Kopete; we consider this to be reasonable, since the user did
+ * expect *something* to happen at the time of the second call. */
gint64 handle_with_time;
/* queue of Approval */
--
1.5.6.5
More information about the telepathy-commits
mailing list