[telepathy-glib/master] Wrote simple dbus-based tests for account manager.

[David Laban]

Note that these tests are very limited, as they stop the mainloop as soon as
the account manager is prepared.
---
 tests/dbus/account-manager.c |  143 ++++++++++++++++++++++++++++++++++++++---
 1 files changed, 132 insertions(+), 11 deletions(-)

diff --git a/tests/dbus/account-manager.c b/tests/dbus/account-manager.c
index ad6a8f7..28291b3 100644
--- a/tests/dbus/account-manager.c
+++ b/tests/dbus/account-manager.c
@@ -17,12 +17,32 @@
 typedef struct {
     GMainLoop *mainloop;
     TpDBusDaemon *dbus;
+    DBusGConnection *bus;
 
-    SimpleAccountManager *service;
+    SimpleAccountManager *service /* initialized in prepare_service */;
     TpAccountManager *am;
+    gboolean prepared /* The result of prepare_finish */;
+    guint timeout_id;
+
     GError *error /* initialized where needed */;
 } Test;
 
+static gboolean
+test_timed_out (gpointer data)
+{
+  Test *test = (Test *) data;
+  g_assert_not_reached ();
+  test->prepared = FALSE;
+  /* Note that this is a completely bogus error, but it only gets returned if
+   * you comment out the g_assert_not_reached() above. */
+  test->error = g_error_new_literal (TP_ERRORS, TP_DBUS_ERROR_INCONSISTENT,
+                                     "timeout");
+  g_print ("about to quit");
+  g_main_loop_quit (test->mainloop);
+  g_print ("just quit");
+  return FALSE;
+}
+
 static void
 setup (Test *test,
        gconstpointer data)
@@ -31,26 +51,30 @@ setup (Test *test,
   tp_debug_set_flags ("all");
 
   test->mainloop = g_main_loop_new (NULL, FALSE);
+
+  g_main_loop_ref (test->mainloop);
   test->dbus = tp_dbus_daemon_dup (NULL);
   g_assert (test->dbus != NULL);
 
   test->am = NULL;
+  test->timeout_id = 0;
 }
 
 static void
 setup_service (Test *test,
        gconstpointer data)
 {
-  DBusGConnection *bus;
-  SimpleAccountManager *service;
 
   setup (test, data);
 
-  bus = tp_get_bus ();
-  service = g_object_new (SIMPLE_TYPE_ACCOUNT_MANAGER, NULL);
-  dbus_g_connection_register_g_object (bus, TP_ACCOUNT_MANAGER_OBJECT_PATH,
-      (GObject *) service);
-  test->service = service;
+  test->bus = tp_get_bus ();
+
+  g_assert (tp_dbus_daemon_request_name (test->dbus,
+          TP_ACCOUNT_MANAGER_BUS_NAME, FALSE, &test->error));
+
+  test->service = g_object_new (SIMPLE_TYPE_ACCOUNT_MANAGER, NULL);
+  dbus_g_connection_register_g_object (test->bus, TP_ACCOUNT_MANAGER_OBJECT_PATH,
+      (GObject *) test->service);
 }
 
 static void
@@ -62,7 +86,11 @@ teardown (Test *test,
       g_object_unref (test->am);
       test->am = NULL;
     }
-
+  if (test->timeout_id != 0)
+    {
+      g_source_remove (test->timeout_id);
+      test->timeout_id = 0;
+    }
   g_object_unref (test->dbus);
   test->dbus = NULL;
   g_main_loop_unref (test->mainloop);
@@ -73,6 +101,9 @@ static void
 teardown_service (Test *test,
           gconstpointer data)
 {
+  g_assert (
+      tp_dbus_daemon_release_name (test->dbus, TP_ACCOUNT_MANAGER_BUS_NAME,
+                               &test->error));
   g_object_unref (test->service);
   test->service = NULL;
   teardown (test, data);
@@ -107,11 +138,93 @@ test_dup (Test *test,
   g_object_unref (one);
 }
 
+/** Tests which use the bus follow this comment. */
+
+/**
+ * Used by test_prepare.
+ */
+static void am_prepare_cb (GObject *source_object,
+    GAsyncResult *res,
+    gpointer user_data)
+{
+  Test *test = (Test *) user_data;
+  TpAccountManager *am = TP_ACCOUNT_MANAGER (source_object);
+  g_assert (test->am == am);
+  test->prepared = tp_account_manager_prepare_finish (am, res, &test->error);
+  g_main_loop_quit (test->mainloop);
+}
+
+/**
+ * Helper function for testing the functionality of prepare. Calls prepare
+ * and then starts the mainloop until it finishes or times out after a second.
+ * Not actually run as a test on its own even though it looks like one.
+ * Note that test_prepare doesn't assert that the prepare
+ * succeeded. Only that it didn't time out. Use test_prepare_success or
+ * test_prepare_fail for this.
+ */
+static void
+test_prepare (Test *test,
+          gconstpointer data G_GNUC_UNUSED)
+{
+  test->am = tp_account_manager_new (test->dbus);
+  tp_account_manager_prepare_async (test->am, NULL, am_prepare_cb, test);
+  test->timeout_id = g_timeout_add (1000, test_timed_out, test);
+  g_main_loop_run (test->mainloop);
+}
+
+/**
+ * Tests the usual case where prepare succeeds.
+ */
 static void
-test_service (Test *test,
+test_prepare_success (Test *test,
           gconstpointer data G_GNUC_UNUSED)
 {
+  test_prepare (test, data);
+  g_assert_no_error (test->error);
+  g_assert (test->prepared);
 }
+
+/**
+ * Tests the case where the well-known name is not provided.
+ * This should be run with setup rather than setup_service to make this the case.
+ * TODO: use g_assert_error (err, dom, c) to fix the domain and code.
+ */
+static void
+test_prepare_no_name (Test *test,
+          gconstpointer data G_GNUC_UNUSED)
+{
+  test_prepare (test, data);
+  g_assert (test->error != NULL);
+  test->error = NULL;
+  g_assert (!test->prepared);
+}
+
+/**
+ * Tests the case where the object has been destroyed.
+ * TODO: use g_assert_error (err, dom, c) to fix the domain and code.
+ */
+static void
+test_prepare_destroyed (Test *test,
+          gconstpointer data G_GNUC_UNUSED)
+{
+  dbus_g_connection_unregister_g_object (test->bus, G_OBJECT (test->service));
+  test_prepare (test, data);
+  g_assert (test->error != NULL);
+  test->error = NULL;
+  g_assert (!test->prepared);
+  dbus_g_connection_register_g_object (test->bus, TP_ACCOUNT_MANAGER_OBJECT_PATH,
+      (GObject *) test->service);
+}
+
+static void
+test_create_success (Test *test,
+          gconstpointer data G_GNUC_UNUSED)
+{
+  test_prepare (test, data);
+  g_assert_no_error (test->error);
+  g_assert (test->prepared);
+}
+
 int
 main (int argc,
       char **argv)
@@ -121,7 +234,15 @@ main (int argc,
 
   g_test_add ("/am/new", Test, NULL, setup, test_new, teardown);
   g_test_add ("/am/dup", Test, NULL, setup, test_dup, teardown);
-  g_test_add ("/am/service", Test, NULL, setup_service, test_service, teardown_service);
 
+  g_test_add ("/am/prepare/success", Test, NULL, setup_service,
+              test_prepare_success, teardown_service);
+  g_test_add ("/am/prepare/destroyed", Test, NULL, setup_service,
+              test_prepare_destroyed, teardown_service);
+  g_test_add ("/am/prepare/name-not-provided", Test, NULL, setup,
+              test_prepare_no_name, teardown);
+
+  g_test_add ("/am/create/success", Test, NULL, setup_service,
+              test_create_success, teardown_service);
   return g_test_run ();
 }
-- 
1.5.6.5