[telepathy-sofiasip/master] Addressed some of Simon's review comments for codec parameter formatting

Mikhail Zabaluev mikhail.zabaluev at nokia.com
Mon Nov 23 04:45:46 PST 2009


---
 tpsip/codec-param-formats.h |    2 +-
 tpsip/util.c                |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/tpsip/codec-param-formats.h b/tpsip/codec-param-formats.h
index b7bf435..2198395 100644
--- a/tpsip/codec-param-formats.h
+++ b/tpsip/codec-param-formats.h
@@ -39,7 +39,7 @@ G_BEGIN_DECLS
  * <literal>a=fmtp</literal> attribute, into the string buffer @out.
  *
  * <note>
- *   <para>The function is allowed to modify the @params hash table.
+ *   <para>The function is allowed to delete pairs from the @params hash table.
  *   This is useful to implement a custom formatter that processes the
  *   few parameters treated specially, removes them from the map, and 
  *   calls a more generic formatter such as tpsip_codec_param_format_generic().
diff --git a/tpsip/util.c b/tpsip/util.c
index c465651..66f66be 100644
--- a/tpsip/util.c
+++ b/tpsip/util.c
@@ -64,7 +64,8 @@ tpsip_string_append_quoted (GString *buf, const gchar *text)
       gchar ch;
 
       /* Get the following text span to append verbatim */
-      for (q = p; !escape_table[ch = *q]; ++q);
+      for (q = p; !escape_table[*q]; ++q)
+        { /* do nothing */ }
       g_string_append_len (buf, p, q - p);
 
       if (ch == '\0')
-- 
1.5.6.5




More information about the telepathy-commits mailing list