[telepathy-gabble/telepathy-gabble-0.8] presence-cache.c: add a FIXME comment about the avatar sha1 being resetted and set in 2 different files

Alban Crequy alban.crequy at collabora.co.uk
Fri Oct 2 05:14:22 PDT 2009


---
 src/presence-cache.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/presence-cache.c b/src/presence-cache.c
index 1ee43f3..36037ef 100644
--- a/src/presence-cache.c
+++ b/src/presence-cache.c
@@ -659,7 +659,13 @@ self_vcard_request_cb (GabbleVCardManager *self,
   if (vcard != NULL)
     {
       sha1 = vcard_get_avatar_sha1 (vcard);
+
+      /* FIXME: presence->avatar_sha1 is resetted in
+       * self_avatar_resolve_conflict() and the following signal set it in
+       * conn-avatars.c. Doing that in 2 different files is confusing.
+       */
       g_signal_emit (cache, signals[AVATAR_UPDATE], 0, handle, sha1);
+
       g_free (sha1);
     }
 }
-- 
1.5.6.5




More information about the telepathy-commits mailing list