[telepathy-mission-control/master] Note that collect_satisfied_requests might be doing unnecessary work as per wjt's review
Simon McVittie
simon.mcvittie at collabora.co.uk
Tue Oct 27 10:27:39 PDT 2009
---
src/mcd-dispatch-operation.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/mcd-dispatch-operation.c b/src/mcd-dispatch-operation.c
index 973d2ba..0d25f68 100644
--- a/src/mcd-dispatch-operation.c
+++ b/src/mcd-dispatch-operation.c
@@ -1471,7 +1471,9 @@ collect_satisfied_requests (GList *channels)
gpointer path;
GPtrArray *ret;
- /* collect object paths into a hash table, to drop duplicates */
+ /* collect object paths into a hash table, to drop duplicates
+ * FIXME (fd.o #24763): this shouldn't be necessary, because there should
+ * never be duplicates, unless my analysis is wrong? */
for (c = channels; c != NULL; c = c->next)
{
const GList *reqs = _mcd_channel_get_satisfied_requests (c->data);
--
1.5.6.5
More information about the telepathy-commits
mailing list