[telepathy-mission-control/master] test/twisted/test-plugin.c: don't leak McdDispatcherContext in reject_with_reason, reject_rickrolling

Simon McVittie simon.mcvittie at collabora.co.uk
Wed Oct 28 11:04:01 PDT 2009


Oops... this is a memory leak, and could also prevent Finished from being
emitted from the corresponding dispatch operations.
---
 test/twisted/test-plugin.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/test/twisted/test-plugin.c b/test/twisted/test-plugin.c
index 6da3b22..89171a3 100644
--- a/test/twisted/test-plugin.c
+++ b/test/twisted/test-plugin.c
@@ -58,7 +58,6 @@ reject_rickrolling (McdDispatcherContext *ctx,
     {
         DEBUG ("rickrolling detected, closing channel %s", object_path);
         mcd_dispatcher_context_destroy_all (ctx);
-        return;
     }
 
     mcd_dispatcher_context_proceed (ctx);
@@ -92,7 +91,6 @@ reject_with_reason (McdDispatcherContext *ctx,
         mcd_dispatcher_context_close_all (ctx,
             TP_CHANNEL_GROUP_CHANGE_REASON_PERMISSION_DENIED,
             "Can't touch this");
-        return;
     }
 
     mcd_dispatcher_context_proceed (ctx);
-- 
1.5.6.5




More information about the telepathy-commits mailing list