[telepathy-mission-control/master] mcd-account: allow setting a parameter to the same value

Jonny Lamb jonny.lamb at collabora.co.uk
Thu Sep 17 17:00:04 PDT 2009


SetParameters checks if the parameter being set is actually being
changed. Previously, it would only move on the list of parameters to
change if it was actually being changed, leading to an endless
loop. However, we want it to carry on even if the parameter is
unchanged.

Signed-off-by: Jonny Lamb <jonny.lamb at collabora.co.uk>
---
 src/mcd-account.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/src/mcd-account.c b/src/mcd-account.c
index 4c6ab3b..9b22d64 100644
--- a/src/mcd-account.c
+++ b/src/mcd-account.c
@@ -2403,7 +2403,12 @@ set_parameters_iter_param (McdAccount *account,
         {
             g_ptr_array_add (data->not_yet, g_strdup (data->param->name));
         }
+    }
 
+    if (account != NULL)
+    {
+        /* Regardless of whether the parameter changed or not, move on
+         * one parameter so we don't get in recursivey death. */
         data->param++;
     }
 
-- 
1.5.6.5



More information about the telepathy-commits mailing list