[telepathy-gabble/telepathy-gabble-0.8] Clarify FIXME about generalizing error-extracting code
Will Thompson
will.thompson at collabora.co.uk
Mon Sep 28 08:03:44 PDT 2009
---
src/vcard-manager.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/vcard-manager.c b/src/vcard-manager.c
index dd2e4cd..3fa9963 100644
--- a/src/vcard-manager.c
+++ b/src/vcard-manager.c
@@ -1086,13 +1086,15 @@ pipeline_reply_cb (GabbleConnection *conn,
GabbleXmppError xmpp_error = XMPP_ERROR_UNDEFINED_CONDITION;
GabbleXmppErrorType error_type = XMPP_ERROR_UNDEFINED_CONDITION;
+ /* FIXME: add a helper in error.c to extract the type, error, and message
+ * from an XMPP stanza.
+ */
if (reply_msg != NULL)
error_node = lm_message_node_get_child (reply_msg->node, "error");
if (error_node != NULL)
xmpp_error = gabble_xmpp_error_from_node (error_node, &error_type);
- /* FIXME: move this code into error.c */
if (error_type == XMPP_ERROR_TYPE_WAIT)
{
DEBUG ("Cannot get <%u>'s vCard now: the server returned the "
--
1.5.6.5
More information about the telepathy-commits
mailing list