[telepathy-mission-control/telepathy-mission-control-5.2] mc_account_conditions_call_when_ready: explain why we ignore the result of _mc_iface_call_when_ready_int

Simon McVittie simon.mcvittie at collabora.co.uk
Mon Sep 28 06:17:39 PDT 2009


---
 libmcclient/mc-account-conditions.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/libmcclient/mc-account-conditions.c b/libmcclient/mc-account-conditions.c
index 8c841aa..da88d69 100644
--- a/libmcclient/mc-account-conditions.c
+++ b/libmcclient/mc-account-conditions.c
@@ -109,6 +109,10 @@ mc_account_conditions_call_when_ready (McAccount *account,
     iface_data.props_data_ptr = (gpointer)&account->priv->conditions_props;
     iface_data.create_props = create_props;
 
+    /* Normally it would be necessary to use the value returned by this
+     * function to decide whether to set up change-notification. However,
+     * Conditions doesn't have change notification anyway, so ignore the
+     * return. (This is a Coverity CHECKED_RETURN false-positive.) */
     _mc_iface_call_when_ready_int ((TpProxy *)account,
 				   (McIfaceWhenReadyCb)callback, user_data,
 				   &iface_data);
-- 
1.5.6.5



More information about the telepathy-commits mailing list