telepathy-glib: Add a comment explaining why _supports_contact_search() does not require THT prop
Xavier Claessens
xclaesse at kemper.freedesktop.org
Tue Apr 17 03:57:57 PDT 2012
Module: telepathy-glib
Branch: master
Commit: dc9ec1cd1f8abe7b298a6871959daeb9c47d94e3
URL: http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=dc9ec1cd1f8abe7b298a6871959daeb9c47d94e3
Author: Xavier Claessens <xavier.claessens at collabora.co.uk>
Date: Tue Apr 17 12:35:21 2012 +0200
Add a comment explaining why _supports_contact_search() does not require THT prop
---
telepathy-glib/capabilities.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/telepathy-glib/capabilities.c b/telepathy-glib/capabilities.c
index c071bdf..34c7972 100644
--- a/telepathy-glib/capabilities.c
+++ b/telepathy-glib/capabilities.c
@@ -734,11 +734,13 @@ tp_capabilities_supports_contact_search (TpCapabilities *self,
tp_value_array_unpack (arr, 2, &fixed, &allowed_properties);
+ /* ContactSearch channel should have ChannelType and TargetHandleType=NONE
+ * but CM implementations are wrong and omitted TargetHandleType,
+ * so it's set in stone now. */
if (g_hash_table_size (fixed) != 1)
continue;
chan_type = tp_asv_get_string (fixed, TP_PROP_CHANNEL_CHANNEL_TYPE);
-
if (tp_strdiff (chan_type, TP_IFACE_CHANNEL_TYPE_CONTACT_SEARCH))
continue;
More information about the telepathy-commits
mailing list