telepathy-idle: build: fix for "make -j" safety

Jonny Lamb jonny at kemper.freedesktop.org
Tue Aug 28 04:13:28 PDT 2012


Module: telepathy-idle
Branch: master
Commit: b092172e56393fad70e472afa26df4f886dfdbc0
URL:    http://cgit.freedesktop.org/telepathy/telepathy-idle/commit/?id=b092172e56393fad70e472afa26df4f886dfdbc0

Author: Dan Winship <danw at gnome.org>
Date:   Fri Aug 24 12:19:45 2012 -0400

build: fix for "make -j" safety

A make rule with multiple (non-pattern) targets just says that each of
those files can be built by the rule, not that the rule builds all of
them at once. So under "make -j", extensions/Makefile would run three
copies of glib-ginterface-gen.py at once, which could end up deleting
each others' files and causing a make failure. Fix.

Signed-off-by: Jonny Lamb <jonny.lamb at collabora.co.uk>

---

 extensions/Makefile.am |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/extensions/Makefile.am b/extensions/Makefile.am
index 24efb6e..bb837da 100644
--- a/extensions/Makefile.am
+++ b/extensions/Makefile.am
@@ -42,7 +42,10 @@ extensions.html: _gen/all.xml $(tools_dir)/doc-generator.xsl
 		$(tools_dir)/doc-generator.xsl \
 		$< > $@
 
-_gen/svc.c _gen/svc.h _gen/svc-gtk-doc.h: _gen/all.xml \
+_gen/svc.h: _gen/svc.c
+_gen/svc-gtk-doc.h: _gen/svc.c
+
+_gen/svc.c: _gen/all.xml \
 	$(tools_dir)/glib-ginterface-gen.py
 	$(AM_V_GEN)$(PYTHON) $(tools_dir)/glib-ginterface-gen.py \
 		--filename=_gen/svc --signal-marshal-prefix=_idle_ext \



More information about the telepathy-commits mailing list