telepathy-salut: request-muc-tubes test: add TODO explaining why a test is commented

Jonny Lamb jonny at kemper.freedesktop.org
Tue Aug 28 06:30:48 PDT 2012


Module: telepathy-salut
Branch: master
Commit: 4a41e871b177a4ebf1aee20c194c2daf6ae2fb92
URL:    http://cgit.freedesktop.org/telepathy/telepathy-salut/commit/?id=4a41e871b177a4ebf1aee20c194c2daf6ae2fb92

Author: Jonny Lamb <jonny.lamb at collabora.co.uk>
Date:   Thu Aug  2 16:53:31 2012 +0100

request-muc-tubes test: add TODO explaining why a test is commented

Signed-off-by: Jonny Lamb <jonny.lamb at collabora.co.uk>

---

 tests/twisted/avahi/tubes/request-muc-tubes.py |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/twisted/avahi/tubes/request-muc-tubes.py b/tests/twisted/avahi/tubes/request-muc-tubes.py
index 72ecbb1..8608fa0 100644
--- a/tests/twisted/avahi/tubes/request-muc-tubes.py
+++ b/tests/twisted/avahi/tubes/request-muc-tubes.py
@@ -74,7 +74,10 @@ def test(q, bus, conn):
     assert props[INITIATOR_ID] == self_name
 
     # ensure the same channel
-#    yours, ensured_path, ensured_props = conn.Requests.EnsureChannel(
+
+# TODO: the muc channel doesn't bother to look at existing tubes
+# before creating a new one. once that's fixed, uncomment this.
+#    yours, ensured_path, _ = conn.Requests.EnsureChannel(
 #            { CHANNEL_TYPE: CHANNEL_TYPE_STREAM_TUBE,
 #              TARGET_HANDLE_TYPE: HT_ROOM,
 #              TARGET_HANDLE: handle,
@@ -82,7 +85,7 @@ def test(q, bus, conn):
 #              })
 
 #    assert not yours
-#    assert ensured_path == tube_path, (ensured_path, tube_path2)
+#    assert ensured_path == tube_path, (ensured_path, tube_path)
 
     conn.Disconnect()
 



More information about the telepathy-commits mailing list