telepathy-glib: TpConnectionManagerParam: seal struct fields

Xavier Claessens xclaesse at kemper.freedesktop.org
Mon Jun 4 04:55:02 PDT 2012


Module: telepathy-glib
Branch: master
Commit: cacba6db63a23df79f67eb149cedecfe1af052e2
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=cacba6db63a23df79f67eb149cedecfe1af052e2

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Fri May  4 16:41:21 2012 +0100

TpConnectionManagerParam: seal struct fields

We have accessors for all of them, and the GValue is going to be a
problem as we move towards GVariant.

---

 telepathy-glib/connection-manager.c |   19 +++++++++++--------
 telepathy-glib/protocol.h           |   13 ++++++-------
 2 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/telepathy-glib/connection-manager.c b/telepathy-glib/connection-manager.c
index fc09d8f..a4c2d61 100644
--- a/telepathy-glib/connection-manager.c
+++ b/telepathy-glib/connection-manager.c
@@ -197,17 +197,20 @@ enum
 
 /**
  * TpConnectionManagerParam:
- * @name: The name of this parameter
- * @dbus_signature: This parameter's D-Bus signature
- * @default_value: This parameter's default value, or an arbitrary value
- *  of an appropriate type if %TP_CONN_MGR_PARAM_FLAG_HAS_DEFAULT is not
- *  set on this parameter, or an unset GValue if the signature is not
- *  recognised by telepathy-glib
- * @flags: This parameter's flags (a combination of #TpConnMgrParamFlags)
- * @priv: Pointer to opaque private data
  *
  * Structure representing a connection manager parameter.
  *
+ * Since 0.UNRELEASED, accessing the fields of this struct is deprecated,
+ * and they are no longer documented here.
+ * Use the accessors tp_connection_manager_protocol_param_get_name(),
+ * tp_connection_manager_protocol_param_get_dbus_signature(),
+ * tp_connection_manager_protocol_param_is_required(),
+ * tp_connection_manager_protocol_param_is_required_for_registration(),
+ * tp_connection_manager_protocol_param_is_secret(),
+ * tp_connection_manager_protocol_param_is_dbus_property(),
+ * tp_connection_manager_protocol_param_get_default(),
+ * tp_connection_manager_protocol_param_dup_default_variant() instead.
+ *
  * Since: 0.7.1
  */
 
diff --git a/telepathy-glib/protocol.h b/telepathy-glib/protocol.h
index 31c4a46..da729a6 100644
--- a/telepathy-glib/protocol.h
+++ b/telepathy-glib/protocol.h
@@ -33,13 +33,12 @@ typedef struct _TpConnectionManagerParam TpConnectionManagerParam;
 
 struct _TpConnectionManagerParam
 {
-  /*<public>*/
-  gchar *name;
-  gchar *dbus_signature;
-  GValue default_value;
-  guint flags;
-
-  gpointer priv;
+  /*<private>*/
+  gchar *_TP_SEAL (name);
+  gchar *_TP_SEAL (dbus_signature);
+  GValue _TP_SEAL (default_value);
+  guint _TP_SEAL (flags);
+  gpointer _TP_SEAL (priv);
 };
 
 typedef struct _TpProtocol TpProtocol;



More information about the telepathy-commits mailing list