[next] telepathy-glib: check-c-style: don't check if GError are initialized

Xavier Claessens xclaesse at kemper.freedesktop.org
Wed May 9 13:10:51 PDT 2012


Module: telepathy-glib
Branch: next
Commit: 05b3d1e1f9d5c63d0d01a9cecc3f04cae3191605
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=05b3d1e1f9d5c63d0d01a9cecc3f04cae3191605

Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Thu May  3 09:54:13 2012 +0200

check-c-style: don't check if GError are initialized

It just leads us to writing insanity like:
  GError *error /* badger */;

---

 tools/check-c-style.sh |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/tools/check-c-style.sh b/tools/check-c-style.sh
index 4330b14..5583420 100644
--- a/tools/check-c-style.sh
+++ b/tools/check-c-style.sh
@@ -3,13 +3,6 @@ fail=0
 
 ( . "${tools_dir}"/check-misc.sh ) || fail=$?
 
-if grep -n '^ *GError *\*[[:alpha:]_][[:alnum:]_]* *;' "$@"
-then
-  echo "^^^ The above files contain uninitialized GError*s - they should be"
-  echo "    initialized to NULL"
-  fail=1
-fi
-
 # The first regex finds function calls like foo() (as opposed to foo ()).
 #   It attempts to ignore string constants (may cause false negatives).
 # The second and third ignore block comments (gtkdoc uses foo() as markup).



More information about the telepathy-commits mailing list