[next] telepathy-glib: TpTextChannel: rephrase comment explaining the case we won't emit chat-state-changed

Xavier Claessens xclaesse at kemper.freedesktop.org
Mon May 14 04:28:11 PDT 2012


Module: telepathy-glib
Branch: next
Commit: 870e3a59ea4c4e4683aaa5fec2f347e887c84590
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=870e3a59ea4c4e4683aaa5fec2f347e887c84590

Author: Xavier Claessens <xavier.claessens at collabora.co.uk>
Date:   Mon May 14 13:24:35 2012 +0200

TpTextChannel: rephrase comment explaining the case we won't emit chat-state-changed

---

 telepathy-glib/text-channel.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/telepathy-glib/text-channel.c b/telepathy-glib/text-channel.c
index c41c37e..91a1d73 100644
--- a/telepathy-glib/text-channel.c
+++ b/telepathy-glib/text-channel.c
@@ -351,10 +351,9 @@ chat_state_changed_cb (TpChannel *channel,
       GUINT_TO_POINTER (handle),
       GUINT_TO_POINTER (state));
 
-  /* We have only an handle, but since we guarantee "chat-state-changed"
-   * to be emitted only if TP_CHANNEL_FEATURE_GROUP has been prepared, we should
-   * already have its TpContact. If the TpContact does not exist, telling its
-   * chat state is useless anyway. */
+  /* We only guarantee to emit chat-state-changed for contacts that exist.
+   * In particular, for 1-1 channels, the peer TpContact already exists, and for
+   * Group channels, the GROUP feature makes all members exist. */
   conn = tp_channel_borrow_connection (channel);
   contact = tp_connection_dup_contact_if_possible (conn, handle, NULL);
   if (contact == NULL)



More information about the telepathy-commits mailing list