telepathy-idle: Prototype functions properly: foo() is not a prototype, foo (void) is

Simon McVittie smcv at kemper.freedesktop.org
Wed May 30 05:08:46 PDT 2012


Module: telepathy-idle
Branch: master
Commit: 33101f04c60d7806b7f77802cc24471ecab9458e
URL:    http://cgit.freedesktop.org/telepathy/telepathy-idle/commit/?id=33101f04c60d7806b7f77802cc24471ecab9458e

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Thu May 10 14:15:32 2012 +0100

Prototype functions properly: foo() is not a prototype, foo(void) is

Signed-off-by: Simon McVittie <simon.mcvittie at collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens at collabora.co.uk>

---

 src/idle-connection.c  |    3 ++-
 src/idle-debug.c       |    3 ++-
 src/idle-debug.h       |    2 +-
 src/idle-im-manager.h  |    2 +-
 src/idle-muc-manager.h |    2 +-
 src/idle.c             |    2 +-
 6 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/idle-connection.c b/src/idle-connection.c
index a2e232e..40d5777 100644
--- a/src/idle-connection.c
+++ b/src/idle-connection.c
@@ -1188,7 +1188,8 @@ void _queue_alias_changed(IdleConnection *conn, TpHandle handle, const gchar *al
 			G_TYPE_INVALID));
 }
 
-static GQuark _canon_nick_quark() {
+static GQuark
+_canon_nick_quark (void) {
 	static GQuark quark = 0;
 
 	if (!quark)
diff --git a/src/idle-debug.c b/src/idle-debug.c
index b335c15..11969d3 100644
--- a/src/idle-debug.c
+++ b/src/idle-debug.c
@@ -36,7 +36,8 @@ static GDebugKey _keys[] = {
 	{NULL, 0}
 };
 
-void idle_debug_init() {
+void
+idle_debug_init (void) {
 	const gchar *flags_string = g_getenv("IDLE_DEBUG");
 	guint nkeys;
 
diff --git a/src/idle-debug.h b/src/idle-debug.h
index a025940..6677d2f 100644
--- a/src/idle-debug.h
+++ b/src/idle-debug.h
@@ -32,7 +32,7 @@ typedef enum {
 	IDLE_DEBUG_TEXT = (1 << 6),
 } IdleDebugFlags;
 
-void idle_debug_init();
+void idle_debug_init (void);
 void idle_debug(IdleDebugFlags flag, const gchar *format, ...) G_GNUC_PRINTF(2, 3);
 
 void idle_debug_free (void);
diff --git a/src/idle-im-manager.h b/src/idle-im-manager.h
index 1967a29..3765de4 100644
--- a/src/idle-im-manager.h
+++ b/src/idle-im-manager.h
@@ -36,7 +36,7 @@ struct _IdleIMManager {
 	GObject parent;
 };
 
-GType idle_im_manager_get_type();
+GType idle_im_manager_get_type (void);
 
 #define IDLE_TYPE_IM_MANAGER (idle_im_manager_get_type())
 #define IDLE_IM_MANAGER(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), IDLE_TYPE_IM_MANAGER, IdleIMManager))
diff --git a/src/idle-muc-manager.h b/src/idle-muc-manager.h
index ee2a3f9..8fc509a 100644
--- a/src/idle-muc-manager.h
+++ b/src/idle-muc-manager.h
@@ -36,7 +36,7 @@ struct _IdleMUCManager {
 	GObject parent;
 };
 
-GType idle_muc_manager_get_type();
+GType idle_muc_manager_get_type (void);
 
 #define IDLE_TYPE_MUC_MANAGER (idle_muc_manager_get_type())
 #define IDLE_MUC_MANAGER(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), IDLE_TYPE_MUC_MANAGER, IdleMUCManager))
diff --git a/src/idle.c b/src/idle.c
index 44585bd..8d3706b 100644
--- a/src/idle.c
+++ b/src/idle.c
@@ -27,7 +27,7 @@
 #include "idle-connection-manager.h"
 #include "idle-debug.h"
 
-static TpBaseConnectionManager *_construct_cm() {
+static TpBaseConnectionManager *_construct_cm (void) {
 	TpBaseConnectionManager *base_cm = TP_BASE_CONNECTION_MANAGER(g_object_new(IDLE_TYPE_CONNECTION_MANAGER, NULL));
 
 	return base_cm;



More information about the telepathy-commits mailing list