telepathy-mission-control: mcd_storage_dup_value: don' t return non-NULL with error set

Simon McVittie smcv at kemper.freedesktop.org
Thu Oct 4 08:19:46 PDT 2012


Module: telepathy-mission-control
Branch: master
Commit: 87b40cf09a3589daca09d9a54b466b0c0572f98b
URL:    http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=87b40cf09a3589daca09d9a54b466b0c0572f98b

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Fri Sep  7 17:37:29 2012 +0100

mcd_storage_dup_value: don't return non-NULL with error set

The practical effect of this is:

* addressing_set_uri_scheme_association() needs modification to cope
  with a NULL return, which previously never happened (an empty
  string-list was returned on error)

* addressing_get_uri_schemes() needs the same change

* mcd_account_get_parameter() treats parameters whose value in the
  keyfile cannot be interpreted as the desired type as if they were
  unset; previously, it treated them as 0, False, "", [], etc.

The old behaviour of mcd_account_get_parameter() seems undesirable:
we shouldn't just make up parameter values. If the parameter is boolean
"require-tls" and its value gets set to 2 for some reason, we should
invalidate the account, rather than setting it to False and carrying on!

---

 src/mcd-account-addressing.c |   27 +++++--
 src/mcd-account.c            |   12 +--
 src/mcd-storage.c            |  192 +++++++++++++++++++++++++-----------------
 3 files changed, 139 insertions(+), 92 deletions(-)

Diff:   http://cgit.freedesktop.org/telepathy/telepathy-mission-control/diff/?id=87b40cf09a3589daca09d9a54b466b0c0572f98b


More information about the telepathy-commits mailing list