telepathy-mission-control: Mark McpAccountStorage::altered as deprecated

Simon McVittie smcv at kemper.freedesktop.org
Thu Oct 4 08:19:47 PDT 2012


Module: telepathy-mission-control
Branch: master
Commit: 9bf797ebf0bac51b3647bd063b47ca8d78c0c84d
URL:    http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=9bf797ebf0bac51b3647bd063b47ca8d78c0c84d

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Mon Sep 10 18:10:52 2012 +0100

Mark McpAccountStorage::altered as deprecated

It would be nice to have, but apparently it doesn't actually work...
so I'm not going to waste any time on it.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=28288

---

 mission-control-plugins/account-storage.c |   12 ++++++------
 mission-control-plugins/account-storage.h |    1 +
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/mission-control-plugins/account-storage.c b/mission-control-plugins/account-storage.c
index f878ab0..fdb9c24 100644
--- a/mission-control-plugins/account-storage.c
+++ b/mission-control-plugins/account-storage.c
@@ -129,16 +129,16 @@ class_init (gpointer klass,
    * McpAccountStorage::altered
    * @account: the unique name of the altered account
    *
-   * emitted if an external entity alters an account
-   * in the backend the emitting plugin handles
-   * should not be emitted if a single known property has been
-   * altered, see McpAccountStorage::altered-one instead
+   * This signal does not appear to be fully implemented
+   * (see <ulink href="https://bugs.freedesktop.org/show_bug.cgi?id=28288"
+   *  >freedesktop.org bug 28288</ulink>).
+   * Emit #McpAccountStorage::altered-one instead.
    *
    * Should not be fired until mcp_account_storage_ready() has been called
    *
-   **/
+   */
   signals[ALTERED] = g_signal_new ("altered",
-      type, G_SIGNAL_RUN_LAST, 0, NULL, NULL,
+      type, G_SIGNAL_RUN_LAST | G_SIGNAL_DEPRECATED, 0, NULL, NULL,
       g_cclosure_marshal_VOID__STRING, G_TYPE_NONE,
       1, G_TYPE_STRING);
 
diff --git a/mission-control-plugins/account-storage.h b/mission-control-plugins/account-storage.h
index 3f08476..0eeb74a 100644
--- a/mission-control-plugins/account-storage.h
+++ b/mission-control-plugins/account-storage.h
@@ -243,6 +243,7 @@ const gchar *mcp_account_storage_provider (const McpAccountStorage *storage);
 
 void mcp_account_storage_emit_created (McpAccountStorage *storage,
     const gchar *account);
+G_DEPRECATED_FOR (something that is actually implemented)
 void mcp_account_storage_emit_altered (McpAccountStorage *storage,
     const gchar *account);
 void mcp_account_storage_emit_altered_one (McpAccountStorage *storage,



More information about the telepathy-commits mailing list