telepathy-mission-control: make-valid test: make connection object paths distinct

Simon McVittie smcv at kemper.freedesktop.org
Mon Oct 8 07:27:43 PDT 2012


Module: telepathy-mission-control
Branch: master
Commit: b265e18157aec3d387b344331fb2aa117f1257bb
URL:    http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=b265e18157aec3d387b344331fb2aa117f1257bb

Author: Jonny Lamb <jonny.lamb at collabora.co.uk>
Date:   Wed Aug 29 18:29:54 2012 +0100

make-valid test: make connection object paths distinct

If these object paths are the same, the factory will use the same
TpConnection (even though they are actually different connections) and
dispatching will happen twice.

Signed-off-by: Jonny Lamb <jonny.lamb at collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Simon McVittie <simon.mcvittie at collabora.co.uk>

---

 tests/twisted/account-manager/make-valid.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/twisted/account-manager/make-valid.py b/tests/twisted/account-manager/make-valid.py
index 457229d..0fd54cd 100644
--- a/tests/twisted/account-manager/make-valid.py
+++ b/tests/twisted/account-manager/make-valid.py
@@ -156,7 +156,7 @@ def test(q, bus, unused):
             interface=cs.tp_name_prefix + '.ConnectionManager',
             handled=False)
 
-    conn = SimulatedConnection(q, bus, 'fakecm', 'fakeprotocol', '_',
+    conn = SimulatedConnection(q, bus, 'fakecm', 'fakeprotocol', 'account1',
             'myself', has_presence=True)
 
     q.dbus_return(e.message, conn.bus_name, conn.object_path, signature='so')
@@ -208,7 +208,7 @@ def test(q, bus, unused):
             interface=cs.tp_name_prefix + '.ConnectionManager',
             handled=False)
 
-    conn = SimulatedConnection(q, bus, 'fakecm', 'fakeprotocol', '_',
+    conn = SimulatedConnection(q, bus, 'fakecm', 'fakeprotocol', 'account2',
             'myself', has_presence=True)
 
     q.dbus_return(e.message, conn.bus_name, conn.object_path, signature='so')



More information about the telepathy-commits mailing list