telepathy-glib: Fix incorrect error on UpdateLocalMediaDescription

Sjoerd Simons sjoerd at kemper.freedesktop.org
Mon Sep 3 02:51:58 PDT 2012


Module: telepathy-glib
Branch: master
Commit: 680a5dd2a492078a0cc497502aab1d81cdba39ac
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=680a5dd2a492078a0cc497502aab1d81cdba39ac

Author: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
Date:   Mon Sep  3 11:10:01 2012 +0200

Fix incorrect error on UpdateLocalMediaDescription

Remove the code that errors out a local description update if there is
*any* outstanding offer. A bit later in the same function a proper check
is done to see if there is a offer for the update contact, which is
correct.

---

 telepathy-glib/base-media-call-content.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/telepathy-glib/base-media-call-content.c b/telepathy-glib/base-media-call-content.c
index a0032f4..b7cf8e1 100644
--- a/telepathy-glib/base-media-call-content.c
+++ b/telepathy-glib/base-media-call-content.c
@@ -683,14 +683,6 @@ tp_base_media_call_content_update_local_media_description (
   GPtrArray *codecs;
   gpointer contact;
 
-  if (self->priv->current_offer != NULL)
-    {
-      GError error = { TP_ERROR, TP_ERROR_NOT_AVAILABLE,
-          "There is a media description offer around so "
-          "UpdateMediaDescription shouldn't be called." };
-      dbus_g_method_return_error (context, &error);
-      return;
-    }
 
   if (!g_hash_table_lookup_extended (properties,
           TP_PROP_CALL_CONTENT_MEDIA_DESCRIPTION_REMOTE_CONTACT,



More information about the telepathy-commits mailing list