telepathy-logger: LogManager: simplify checking for duplicate stores
Will Thompson
wjt at kemper.freedesktop.org
Thu Sep 27 10:29:01 PDT 2012
Module: telepathy-logger
Branch: master
Commit: d2bb2390c8598183d23a06ecc99705e6b0a94dbb
URL: http://cgit.freedesktop.org/telepathy/telepathy-logger/commit/?id=d2bb2390c8598183d23a06ecc99705e6b0a94dbb
Author: Will Thompson <will.thompson at collabora.co.uk>
Date: Tue Sep 25 18:57:00 2012 -0400
LogManager: simplify checking for duplicate stores
---
telepathy-logger/log-manager.c | 12 +++---------
1 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/telepathy-logger/log-manager.c b/telepathy-logger/log-manager.c
index 87ebb2a..7a75f37 100644
--- a/telepathy-logger/log-manager.c
+++ b/telepathy-logger/log-manager.c
@@ -393,8 +393,8 @@ _tpl_log_manager_register_log_store (TplLogManager *self,
TplLogStore *logstore)
{
TplLogManagerPriv *priv = self->priv;
+ const gchar *name = _tpl_log_store_get_name (logstore);
GList *l;
- gboolean found = FALSE;
g_return_val_if_fail (TPL_IS_LOG_MANAGER (self), FALSE);
g_return_val_if_fail (TPL_IS_LOG_STORE (logstore), FALSE);
@@ -403,19 +403,13 @@ _tpl_log_manager_register_log_store (TplLogManager *self,
for (l = priv->stores; l != NULL; l = g_list_next (l))
{
TplLogStore *store = l->data;
- const gchar *name = _tpl_log_store_get_name (logstore);
if (!tp_strdiff (name, _tpl_log_store_get_name (store)))
{
- found = TRUE;
- break;
+ DEBUG ("name=%s: already registered", name);
+ return FALSE;
}
}
- if (found)
- {
- DEBUG ("name=%s: already registered", _tpl_log_store_get_name (logstore));
- return FALSE;
- }
if (_tpl_log_store_is_readable (logstore))
priv->readable_stores = g_list_prepend (priv->readable_stores, logstore);
More information about the telepathy-commits
mailing list