telepathy-mission-control: Remove McdAccount:: connection-status-changed signal

Simon McVittie smcv at kemper.freedesktop.org
Wed Jan 9 06:16:57 PST 2013


Module: telepathy-mission-control
Branch: master
Commit: d9d0d64c5046668a0e7dc261216672143a699559
URL:    http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=d9d0d64c5046668a0e7dc261216672143a699559

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Tue Oct  9 16:00:48 2012 +0100

Remove McdAccount::connection-status-changed signal

Nothing listens to it.

Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39334

---

 src/mcd-account.c |   17 -----------------
 1 files changed, 0 insertions(+), 17 deletions(-)

diff --git a/src/mcd-account.c b/src/mcd-account.c
index f26dd1d..2d7f130 100644
--- a/src/mcd-account.c
+++ b/src/mcd-account.c
@@ -198,7 +198,6 @@ enum
 
 enum
 {
-    CONNECTION_STATUS_CHANGED,
     VALIDITY_CHANGED,
     CONNECTION_PATH_CHANGED,
     LAST_SIGNAL
@@ -3579,14 +3578,6 @@ mcd_account_class_init (McdAccountClass * klass)
                                FALSE,
                                G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
     /* Signals */
-    _mcd_account_signals[CONNECTION_STATUS_CHANGED] =
-	g_signal_new ("connection-status-changed",
-		      G_OBJECT_CLASS_TYPE (klass),
-		      G_SIGNAL_RUN_LAST | G_SIGNAL_DETAILED,
-		      0,
-		      NULL, NULL, NULL,
-		      G_TYPE_NONE,
-		      2, G_TYPE_UINT, G_TYPE_UINT);
     _mcd_account_signals[VALIDITY_CHANGED] =
 	g_signal_new ("validity-changed",
 		      G_OBJECT_CLASS_TYPE (klass),
@@ -4449,11 +4440,6 @@ _mcd_account_set_connection_status (McdAccount *account,
     mcd_account_thaw_properties (account);
 
     process_online_requests (account, status, reason);
-
-    if (changed)
-	g_signal_emit (account,
-		       _mcd_account_signals[CONNECTION_STATUS_CHANGED], 0,
-		       status, reason);
 }
 
 TpConnectionStatus
@@ -4463,9 +4449,6 @@ mcd_account_get_connection_status (McdAccount *account)
     return priv->conn_status;
 }
 
-/* FIXME: if this was only called from _mcd_account_set_connection_status,
- * we could combine CONNECTION_STATUS_CHANGED and CONNECTION_PATH_CHANGED
- * into one signal... but for now, this is also called from McdConnection */
 void
 _mcd_account_tp_connection_changed (McdAccount *account,
                                     TpConnection *tp_conn)



More information about the telepathy-commits mailing list