telepathy-glib: tp_debug_client_get_messages_finish: fix annotation

Simon McVittie smcv at kemper.freedesktop.org
Mon Jun 10 07:06:28 PDT 2013


Module: telepathy-glib
Branch: master
Commit: b47a9af03b3154401cdd863f6b76c2393e2e7e39
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=b47a9af03b3154401cdd863f6b76c2393e2e7e39

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Fri Jun  7 17:42:15 2013 +0100

tp_debug_client_get_messages_finish: fix annotation

Returning a GPtrArray with (transfer full) means the caller is expected
to do the equivalent of:

    g_ptr_array_foreach (pa, (GFunc) g_free, NULL);
    g_ptr_array_unref (pa);

whereas we just want them to unref it. This crashed my g-i-based
debug-client.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65518
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>

---

 telepathy-glib/debug-client.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/telepathy-glib/debug-client.c b/telepathy-glib/debug-client.c
index 113ac3f..89712db 100644
--- a/telepathy-glib/debug-client.c
+++ b/telepathy-glib/debug-client.c
@@ -536,8 +536,8 @@ tp_debug_client_get_messages_async (
  *
  * Finishes tp_debug_client_set_enabled_async().
  *
- * Returns: (transfer full) (type GLib.PtrArray) (element-type TelepathyGLib.DebugMessage):
- * a #GPtrArray of #TpDebugMessage
+ * Returns: (transfer container) (type GLib.PtrArray) (element-type TelepathyGLib.DebugMessage):
+ * a #GPtrArray of #TpDebugMessage, free with g_ptr_array_unref()
  *
  * Since: 0.19.0
  */



More information about the telepathy-commits mailing list