telepathy-idle: Don't crash when a channel with multiple requests fails

Sjoerd Simons sjoerd at kemper.freedesktop.org
Mon May 13 03:58:26 PDT 2013


Module: telepathy-idle
Branch: master
Commit: 68f8a01b0d03ddac1cca102283c79fac907fa388
URL:    http://cgit.freedesktop.org/telepathy/telepathy-idle/commit/?id=68f8a01b0d03ddac1cca102283c79fac907fa388

Author: Sjoerd Simons <sjoerd at luon.net>
Date:   Sun May 12 11:52:49 2013 +0200

Don't crash when a channel with multiple requests fails

The iteration over the channel requests tokens accidentally used the
wrong variable, causing the same request token to be passed into tp-glib
all the time causing crashes..

---

 src/idle-muc-manager.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/idle-muc-manager.c b/src/idle-muc-manager.c
index faf66e9..fdff375 100644
--- a/src/idle-muc-manager.c
+++ b/src/idle-muc-manager.c
@@ -741,7 +741,7 @@ static void _channel_join_ready_cb(IdleMUCChannel *chan, guint err, gpointer use
 			break;
 	}
 
-	for (l = reqs; reqs != NULL; reqs = reqs->next) {
+	for (l = reqs; l != NULL; l = l->next) {
 		tp_channel_manager_emit_request_failed(manager, l->data, TP_ERROR, err_code, err_msg);
 	}
 



More information about the telepathy-commits mailing list