[next] telepathy-spec: Renaming: emit new identifier in Renamed signals

Simon McVittie smcv at kemper.freedesktop.org
Mon Nov 4 14:41:24 CET 2013


Module: telepathy-spec
Branch: next
Commit: fd0103d3786249bf12a9dc1533c499c10f607cdd
URL:    http://cgit.freedesktop.org/telepathy/telepathy-spec/commit/?id=fd0103d3786249bf12a9dc1533c499c10f607cdd

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Mon Oct 14 17:19:18 2013 +0100

Renaming: emit new identifier in Renamed signals

As a general design principle, signals that announce a new handle
should announce its identifier too. This lets client libraries
construct a TpContact, Tp::Contact etc. without a round trip.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=25147
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>

---

 spec/Connection_Interface_Renaming1.xml |   14 +++++++++++++-
 1 files changed, 13 insertions(+), 1 deletions(-)

diff --git a/spec/Connection_Interface_Renaming1.xml b/spec/Connection_Interface_Renaming1.xml
index 7c480da..5a5e2b7 100644
--- a/spec/Connection_Interface_Renaming1.xml
+++ b/spec/Connection_Interface_Renaming1.xml
@@ -27,11 +27,23 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
           The handle of the original identifier
         </tp:docstring>
       </arg>
-      <arg name="New" type="u" tp:type="Contact_Handle">
+      <arg name="New_Handle" type="u" tp:type="Contact_Handle">
         <tp:docstring>
           The handle of the new identifier
         </tp:docstring>
       </arg>
+      <arg name="New_Identifier" type="s">
+        <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
+          <p>The normalized identifier corresponding to New_Handle.</p>
+
+          <tp:rationale>
+            <p>Providing this immediately means that client libraries
+              can do useful things with this signal (log the change,
+              construct contact objects, etc.) without an additional
+              round-trip to find the corresponding string.</p>
+          </tp:rationale>
+        </tp:docstring>
+      </arg>
       <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
         <p>Emitted when the unique identifier of a contact on the server
           changes.</p>



More information about the telepathy-commits mailing list