[next] telepathy-mission-control: McdCreateAccountData: correctly free the user-data

Simon McVittie smcv at kemper.freedesktop.org
Tue Nov 5 14:25:07 CET 2013


Module: telepathy-mission-control
Branch: next
Commit: 07856ce5c068418b2712658d6034f8746b5236a2
URL:    http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=07856ce5c068418b2712658d6034f8746b5236a2

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Tue Oct 15 18:10:49 2013 +0100

McdCreateAccountData: correctly free the user-data

In theory this is a bugfix, but nothing within MC actually calls
this function with a non-NULL GDestroyNotify anyway, and it isn't API.

Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34640

---

 src/mcd-account-manager.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/mcd-account-manager.c b/src/mcd-account-manager.c
index 029c0c2..cd10461 100644
--- a/src/mcd-account-manager.c
+++ b/src/mcd-account-manager.c
@@ -653,6 +653,9 @@ mcd_create_account_data_free (McdCreateAccountData *cad)
     if (G_UNLIKELY (cad->error))
         g_error_free (cad->error);
 
+    if (cad->destroy != NULL)
+        cad->destroy (cad->user_data);
+
     g_free (cad->cm_name);
     g_free (cad->protocol_name);
     g_free (cad->display_name);



More information about the telepathy-commits mailing list