telepathy-mission-control: Replace McdAccount:: always-on with the existing TpStorageRestrictionFlags

[Xavier Claessens]

Module: telepathy-mission-control
Branch: master
Commit: 7825a35bd44859830b8db0f37846457bd1e9aedb
URL:    http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=7825a35bd44859830b8db0f37846457bd1e9aedb

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Fri Nov  8 16:25:32 2013 +0000

Replace McdAccount::always-on with the existing TpStorageRestrictionFlags

I used CANNOT_SET_PRESENCE to control access to ConnectAutomatically
as well as the obvious AutomaticPresence and RequestedPresence, because
RequestedPresence is not under the storage plugin's control - it is
derived from ConnectAutomatically and AutomaticPresence at runtime.

Use MCD_DBUS_PROP_SET_FLAG_ALREADY_IN_STORAGE as a way to bypass the
storage restriction flags, so that storage plugins themselves can
alter enabledness etc. even if they don't allow MC to change it.

The regression test for this initially failed, because toggled_cb()
did not pass that flag to the McdAccount: fix that too.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71390

---

 src/mcd-account-manager.c                          |    2 +-
 src/mcd-account-priv.h                             |    2 -
 src/mcd-account.c                                  |  127 +++++++--------
 tests/twisted/Makefile.am                          |    1 +
 .../account-manager/backend-makes-changes.py       |    3 +-
 .../twisted/account-manager/restricted-storage.py  |  165 ++++++++++++++++++++
 tests/twisted/constants.py                         |    6 +
 tests/twisted/dbus-account-plugin.c                |   30 ++--
 tests/twisted/fakeaccountsservice.py               |    7 +-
 9 files changed, 257 insertions(+), 86 deletions(-)

Diff:   http://cgit.freedesktop.org/telepathy/telepathy-mission-control/diff/?id=7825a35bd44859830b8db0f37846457bd1e9aedb