telepathy-mission-control: mctest: fix invalid method implementations

Simon McVittie smcv at kemper.freedesktop.org
Tue Oct 29 15:50:48 CET 2013


Module: telepathy-mission-control
Branch: master
Commit: d6347f3d7eeaa6fd12185ccfc519d895a21d796e
URL:    http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=d6347f3d7eeaa6fd12185ccfc519d895a21d796e

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Tue Oct 29 13:37:11 2013 +0000

mctest: fix invalid method implementations

There's no variable called s - I wanted a string "s". The relevant test,
account-manager/param-types.py, only failed intermittently, because
it's a matter of timing whether telepathy-glib loads the .manager file
or introspects the ConnectionManager.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71001
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>

---

 tests/twisted/mctest.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/twisted/mctest.py b/tests/twisted/mctest.py
index debc6f4..b093ee8 100644
--- a/tests/twisted/mctest.py
+++ b/tests/twisted/mctest.py
@@ -1090,7 +1090,7 @@ class SimulatedConnectionManager(object):
                     ('i', 0, 'i', dbus.Int32(0)),
                     ('x', 0, 'x', dbus.Int64(0)),
                     ('d', 0, 'd', 0.0),
-                    ('as', 0, 'as', dbus.Array(signature=s)),
+                    ('as', 0, 'as', dbus.Array(signature='s')),
                     ('y', 0, 'y', dbus.Byte(0)),
                     ], signature='(susv)')
 
@@ -1107,7 +1107,7 @@ class SimulatedConnectionManager(object):
                     ('x', cs.PARAM_HAS_DEFAULT, 'x', dbus.Int64(-1)),
                     ('d', cs.PARAM_HAS_DEFAULT, 'd', 1.5),
                     ('as', cs.PARAM_HAS_DEFAULT, 'as',
-                        dbus.Array(['foo', 'bar', 'baz'], signature=s)),
+                        dbus.Array(['foo', 'bar', 'baz'], signature='s')),
                     ('y', cs.PARAM_HAS_DEFAULT, 'y', dbus.Byte(1)),
                     ], signature='(susv)')
 



More information about the telepathy-commits mailing list