telepathy-glib: extended-client: comment that we're going behind MC's back

Simon McVittie smcv at kemper.freedesktop.org
Fri Sep 6 08:09:12 PDT 2013


Module: telepathy-glib
Branch: master
Commit: de7e9b604dd50cb9fcadf3b226d049a9f3cf7ce3
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=de7e9b604dd50cb9fcadf3b226d049a9f3cf7ce3

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Fri Sep  6 12:18:36 2013 +0100

extended-client: comment that we're going behind MC's back

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>

---

 examples/client/extended-client.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/examples/client/extended-client.c b/examples/client/extended-client.c
index 8572b63..55e3086 100644
--- a/examples/client/extended-client.c
+++ b/examples/client/extended-client.c
@@ -212,7 +212,7 @@ cm_requested_connection (TpConnectionManager *manager,
   if (die_if (error, "RequestConnection()"))
     return;
 
-  /* FIXME: there should be convenience API for this */
+  /* Because we don't have an AccountManager, we have to do more work here. */
   factory = tp_simple_client_factory_new (NULL);
   conn = tp_simple_client_factory_ensure_connection (factory, object_path, NULL,
       &e);
@@ -257,6 +257,9 @@ connection_manager_got_info (TpConnectionManager *cm,
       g_value_set_static_string (&value, "myself at server");
       g_hash_table_insert (params, "account", &value);
 
+      /* This example is rather lower-level than most: it's
+       * "going behind the account manager's back". This is not recommended
+       * in real applications. */
       tp_cli_connection_manager_call_request_connection (cm,
           -1, "example", params, cm_requested_connection, NULL, NULL, NULL);
 



More information about the telepathy-commits mailing list