[next] telepathy-glib: Annotate tp_account_update_parameters_finish properly.

Simon McVittie smcv at kemper.freedesktop.org
Thu Sep 12 08:20:20 PDT 2013


Module: telepathy-glib
Branch: next
Commit: 0bd9bf84699cff0c9d9165562ac203ba9eae65b2
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=0bd9bf84699cff0c9d9165562ac203ba9eae65b2

Author: Will Thompson <will.thompson at collabora.co.uk>
Date:   Wed Jan 23 11:34:20 2013 +0000

Annotate tp_account_update_parameters_finish properly.

kuuko discovered that unset_parameters is wrongly inferred to be a
string argument, not a string array argument. At runtime, passing a
string crashes. I think this is a bug in gobject-introspection but we
can annotate it as an array to fix this particular function.

(cherry picked from commit 66982e6c17691869aa17c00416d61674b5b3e34f)
Reviewed-by: Simon McVittie <simon.mcvittie at collabora.co.uk>

---

 telepathy-glib/account.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/telepathy-glib/account.c b/telepathy-glib/account.c
index 1bc8f36..ff33ab1 100644
--- a/telepathy-glib/account.c
+++ b/telepathy-glib/account.c
@@ -2720,7 +2720,7 @@ tp_account_update_parameters_finish (TpAccount *account,
  * @account: a #TpAccount
  * @parameters: (transfer none): a variant of type %G_VARIANT_TYPE_VARDICT
  *  containing new parameters to set on @account
- * @unset_parameters: list of parameters to unset on @account
+ * @unset_parameters: (array zero-terminated=1): list of parameters to unset on @account
  * @callback: a callback to call when the request is satisfied
  * @user_data: data to pass to @callback
  *



More information about the telepathy-commits mailing list