[next] telepathy-glib: TpConnection: don' t recommend that applications call Connect()

Simon McVittie smcv at kemper.freedesktop.org
Fri Sep 13 09:21:05 PDT 2013


Module: telepathy-glib
Branch: next
Commit: 0ed8a3af94781475354aec323a8e225787f07a48
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=0ed8a3af94781475354aec323a8e225787f07a48

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Fri Sep  6 12:01:51 2013 +0100

TpConnection: don't recommend that applications call Connect()

For most applications, the rule is "the account manager does that".

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>

---

 telepathy-glib/connection.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/telepathy-glib/connection.c b/telepathy-glib/connection.c
index 177d1fe..cc648ad 100644
--- a/telepathy-glib/connection.c
+++ b/telepathy-glib/connection.c
@@ -144,8 +144,12 @@ tp_connection_get_feature_quark_core (void)
  *   <title>Someone still has to call Connect()</title>
  *   <para>Requesting this feature via tp_proxy_prepare_async() means that
  *     you want to wait for the connection to connect, but it doesn't actually
- *     start the process of connecting: to do that, call
- *     tp_cli_connection_call_connect() separately.</para>
+ *     start the process of connecting. For connections associated with
+ *     a #TpAccount, the account manager service is responsible for
+ *     doing that, but if you are constructing connections directly
+ *     (e.g. if you are implementing an account manager), you must
+ *     tp_cli_connection_call_connect() separately.
+ *     </para>
  * </note>
  *
  * One can ask for a feature to be prepared using the



More information about the telepathy-commits mailing list