telepathy-mission-control: Always use run-test.sh to run tests
Simon McVittie
smcv at kemper.freedesktop.org
Thu Sep 19 11:42:53 PDT 2013
Module: telepathy-mission-control
Branch: master
Commit: 1978058f83f3bb30196985302fd917cb43473cfa
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=1978058f83f3bb30196985302fd917cb43473cfa
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Sep 18 15:27:42 2013 +0100
Always use run-test.sh to run tests
There are three modes here:
- make check: run tests in ${srcdir} against MC in ${builddir}
- make installcheck: run tests in ${srcdir} against MC in
${DESTDIR}${prefix}
- ${mctestsdir}/twisted/run-test.sh: run tests in ${mctestsdir}
against MC in ${prefix}
Also simplify the last of those cases, and avoid a potential symlink
attack, by requiring that the current working directory for run-test.sh
is a directory controlled by us. In practice we already required that,
because with-session-bus.sh creates files in the current directory.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
---
tests/twisted/Makefile.am | 123 ++++++++--------------------------
tests/twisted/README | 6 +-
tests/twisted/run-test.sh.in | 148 ++++++++++++++++++++++++++++++++++--------
3 files changed, 151 insertions(+), 126 deletions(-)
Diff: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/diff/?id=1978058f83f3bb30196985302fd917cb43473cfa
More information about the telepathy-commits
mailing list