[next] telepathy-mission-control: tests: make sure to specify a D-Bus interface for method calls

Simon McVittie smcv at kemper.freedesktop.org
Thu Apr 3 07:28:04 PDT 2014


Module: telepathy-mission-control
Branch: next
Commit: 3946c981d1f155631294bdeb07ae6aceb9a821f0
URL:    http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=3946c981d1f155631294bdeb07ae6aceb9a821f0

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Fri Mar 21 18:36:12 2014 +0000

tests: make sure to specify a D-Bus interface for method calls

GDBus doesn't implement method calls that lack an explicit interface.
This is A Good Thingâ„¢.

---

 tests/twisted/account-requests/cancel.py                        |    4 ++--
 tests/twisted/account-requests/create-text.py                   |    2 +-
 tests/twisted/account-requests/delete-account-during-request.py |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/twisted/account-requests/cancel.py b/tests/twisted/account-requests/cancel.py
index 2bec7b1..a4f0cc8 100644
--- a/tests/twisted/account-requests/cancel.py
+++ b/tests/twisted/account-requests/cancel.py
@@ -82,13 +82,13 @@ def test(q, bus, mc):
     assert request_props['UserActionTime'] == user_action_time
 
     # chat UI connects to signals and calls ChannelRequest.Proceed()
-    cr.Proceed()
+    cr.Proceed(dbus_interface=cs.CR)
     cm_request_call = q.expect('dbus-method-call',
                 interface=cs.CONN_IFACE_REQUESTS, method='CreateChannel',
                 path=conn.object_path, args=[request], handled=False)
 
     # Actually, never mind.
-    cr.Cancel()
+    cr.Cancel(dbus_interface=cs.CR)
 
     # Time passes. A channel is returned.
     channel_immutable = dbus.Dictionary(request)
diff --git a/tests/twisted/account-requests/create-text.py b/tests/twisted/account-requests/create-text.py
index f52346e..c230038 100644
--- a/tests/twisted/account-requests/create-text.py
+++ b/tests/twisted/account-requests/create-text.py
@@ -104,7 +104,7 @@ def test_channel_creation(q, bus, account, client, conn, ensure):
     q.dbus_return(add_request.message, signature='')
 
     # chat UI connects to signals and calls ChannelRequest.Proceed()
-    cr.Proceed()
+    cr.Proceed(dbus_interface=cs.CR)
     cm_request_call = q.expect('dbus-method-call',
                 interface=cs.CONN_IFACE_REQUESTS,
                 method=(ensure and 'EnsureChannel' or 'CreateChannel'),
diff --git a/tests/twisted/account-requests/delete-account-during-request.py b/tests/twisted/account-requests/delete-account-during-request.py
index 2f2a33c..3e80610 100644
--- a/tests/twisted/account-requests/delete-account-during-request.py
+++ b/tests/twisted/account-requests/delete-account-during-request.py
@@ -75,7 +75,7 @@ def test(q, bus, mc):
 
     # chat UI connects to signals and calls ChannelRequest.Proceed()
     cr = bus.get_object(cs.CD, request_path)
-    cr.Proceed()
+    cr.Proceed(dbus_interface=cs.CR)
     cm_request_call = q.expect('dbus-method-call',
                 interface=cs.CONN_IFACE_REQUESTS, method='CreateChannel',
                 path=conn.object_path, args=[request], handled=False)



More information about the telepathy-commits mailing list