[next] telepathy-spec: Revert "Flatten Requests interface into Connection"

Simon McVittie smcv at kemper.freedesktop.org
Wed Jan 15 04:47:05 PST 2014


Module: telepathy-spec
Branch: next
Commit: 4f3bd60325a539bcbf1056fe90add1e2468ce005
URL:    http://cgit.freedesktop.org/telepathy/telepathy-spec/commit/?id=4f3bd60325a539bcbf1056fe90add1e2468ce005

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Wed Jan 15 12:27:52 2014 +0000

Revert "Flatten Requests interface into Connection"

This reverts commit 28c6e0d0454efc54f9a24da631eb75e6fcf925ba.

I decided against it:

> This might actually not be such a great idea. EnsureChannel and
> CreateChannel should clearly be core, and RequestableChannelClasses
> (aka TP_CONNECTION_FEATURE_CAPABILITIES) can reasonably be core
> while connected, but Channels (and its change-notification,
> NewChannel(s) and ChannelClosed) are sufficiently special-purpose
> that I think only the AM and regression tests should be using it.
> Having the Channels and their immutable properties in the GetAll
> result seems non-optimal.

Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>

---

 doc/templates/interface.html                       |   20 +-
 spec/Channel.xml                                   |    4 +-
 spec/Channel_Dispatch_Operation.xml                |    2 +-
 spec/Channel_Dispatcher.xml                        |    6 +-
 spec/Channel_Dispatcher_Interface_Messages1.xml    |    2 +-
 spec/Channel_Interface_Addressing1.xml             |    2 +-
 spec/Channel_Interface_Conference1.xml             |   14 +-
 spec/Channel_Interface_SMS1.xml                    |    2 +-
 spec/Channel_Interface_Tube1.xml                   |    6 +-
 spec/Channel_Request.xml                           |    6 +-
 spec/Channel_Type_Call1.xml                        |    8 +-
 spec/Channel_Type_Contact_Search1.xml              |   12 +-
 spec/Channel_Type_DBus_Tube1.xml                   |    4 +-
 spec/Channel_Type_File_Transfer1.xml               |   18 +-
 spec/Channel_Type_Room_List1.xml                   |    2 +-
 spec/Channel_Type_Server_Authentication1.xml       |    2 +-
 spec/Channel_Type_Server_TLS_Connection1.xml       |    2 +-
 spec/Channel_Type_Stream_Tube1.xml                 |    4 +-
 spec/Channel_Type_Text.xml                         |    2 +-
 spec/Client_Observer.xml                           |    4 +-
 spec/Connection.xml                                |  552 +-----------------
 .../Connection_Interface_Contact_Capabilities1.xml |    2 +-
 spec/Connection_Interface_Requests.xml             |  595 ++++++++++++++++++++
 spec/Protocol.xml                                  |    6 +-
 spec/Protocol_Interface_Addressing1.xml            |    2 +-
 spec/all.xml                                       |    2 +
 26 files changed, 671 insertions(+), 610 deletions(-)

Diff:   http://cgit.freedesktop.org/telepathy/telepathy-spec/diff/?id=4f3bd60325a539bcbf1056fe90add1e2468ce005


More information about the telepathy-commits mailing list