telepathy-mission-control: dbus-account-plugin: update internal cache correctly

Simon McVittie smcv at kemper.freedesktop.org
Thu Jan 30 04:34:41 PST 2014


Module: telepathy-mission-control
Branch: master
Commit: 93b822857d1898caed819baad7680a10a23e0486
URL:    http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=93b822857d1898caed819baad7680a10a23e0486

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Thu Nov 14 16:29:02 2013 +0000

dbus-account-plugin: update internal cache correctly

The backend-makes-changes test replaces an typed parameter with an
untyped parameter. We correctly signalled the change to MC,
but didn't update the internal cache; the rather strange way in
which MC receives attributes/parameters masked this bug.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727

---

 tests/twisted/dbus-account-plugin.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/twisted/dbus-account-plugin.c b/tests/twisted/dbus-account-plugin.c
index e43d40e..7eaccc3 100644
--- a/tests/twisted/dbus-account-plugin.c
+++ b/tests/twisted/dbus-account-plugin.c
@@ -581,6 +581,7 @@ test_dbus_account_plugin_process_parameters (TestDBusAccountPlugin *self,
               (stored == NULL ||
                !g_variant_equal (value, stored)))
             {
+              g_hash_table_remove (account->parameters, param);
               g_hash_table_insert (account->untyped_parameters,
                   g_strdup (param), g_strdup (escaped));
               key = g_strdup_printf ("param-%s", param);



More information about the telepathy-commits mailing list