telepathy-mission-control: mcp_account_storage_get: replace with get_attribute, get_parameter

Simon McVittie smcv at kemper.freedesktop.org
Thu Jan 30 04:34:41 PST 2014


Module: telepathy-mission-control
Branch: master
Commit: 03c99601d7a76fbc49ed376cd9c30ca631bc085f
URL:    http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=03c99601d7a76fbc49ed376cd9c30ca631bc085f

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Thu Nov 14 16:20:21 2013 +0000

mcp_account_storage_get: replace with get_attribute, get_parameter

The old API in which plugins poked new values into the McdStorage
was non-obvious, and also fundamentally incompatible with the idea
that each account is owned by at most one plugin: if an account
in a high-priority plugin is masked by one in a low-priority plugin,
the McdStorage can't prevent the low-priority plugin from changing
its effective attribute and parameter values.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727

---

 mission-control-plugins/account-storage.c |  149 ++++++++++------
 mission-control-plugins/account-storage.h |   36 ++--
 mission-control-plugins/account.c         |   94 -----------
 mission-control-plugins/account.h         |   17 --
 mission-control-plugins/implementation.h  |   17 --
 src/mcd-account-manager-default.c         |  130 +++++---------
 src/mcd-storage.c                         |  263 +++++------------------------
 src/mcd-storage.h                         |    2 +-
 tests/twisted/dbus-account-plugin.c       |  163 ++++++------------
 tests/twisted/mcp-account-diversion.c     |   71 ++++----
 10 files changed, 300 insertions(+), 642 deletions(-)

Diff:   http://cgit.freedesktop.org/telepathy/telepathy-mission-control/diff/?id=03c99601d7a76fbc49ed376cd9c30ca631bc085f


More information about the telepathy-commits mailing list