New commits on branch next
Simon McVittie
smcv at kemper.freedesktop.org
Wed Mar 19 11:42:21 PDT 2014
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=e1f992dc0dbb0b75684e1a8c981316cfb84809e8
Merge: 404f678 f3fef7b
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Mar 19 18:36:26 2014 +0000
Merge branch 'master' into next
Conflicts:
src/mcd-storage.c
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=404f67814a6bbf71fba965211becbf8cbd9a64af
Merge: 2e69031 553acd8
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Mar 19 18:35:21 2014 +0000
Merge commit '553acd80fac93fb21c28cb51f00c9c51045c9921' into next
Conflicts:
configure.ac
src/mcd-account-connection.c
src/mcd-account-manager.c
src/mcd-account.c
src/mcd-account.h
tools/glib-client-gen.py
tools/glib-client-marshaller-gen.py
tools/glib-ginterface-gen.py
tools/glib-gtypes-generator.py
tools/libglibcodegen.py
tools/libtpcodegen.py
xml/all.xml
xml/telepathy-types.xml
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=2e6903197e84c87f27ca150ef09aaaf0a858ad33
Merge: 4aed09f 79f0081
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Mar 19 18:24:04 2014 +0000
Merge commit '79f0081b0a50ab59794827dd5af79f8671870fcd' into next
Modifications:
* stub out 5-12 and 5-14 tests
* replace Valid, Invalid with Usable, Unusable in new tests
* replace AccountPropertiesChanged with PropertiesChanged in new tests
* use telepathy-1 paths in new tests
Conflicts:
configure.ac
src/mcd-account-manager.c
src/mcd-storage.h
tests/twisted/Makefile.am
tests/twisted/account-manager/avatar-refresh.py
tests/twisted/account-storage/default-keyring-storage.py
util/mc-tool.c
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=f3fef7babc1003737455bb1984fcd09442ab53cc
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Feb 6 16:12:01 2014 +0000
run-test.sh: output in TAP format, and install an installed-tests wrapper
See:
https://wiki.gnome.org/action/show/Initiatives/GnomeGoals/InstalledTests
https://en.wikipedia.org/wiki/Test_Anything_Protocol
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74626
Reviewed-by: Guillaume Desmottes
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=0f68a60c8d6ef710b430cc72d61849e5f2f5860e
Author: Xavier Claessens <xavier.claessens at collabora.co.uk>
Date: Fri Jan 24 16:33:28 2014 -0500
McdAccount: Set "account-path-suffix" parameter on CMs that support it
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=6964c54760f54ccad52f17ed739ea40c3665c96a
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Feb 5 17:23:08 2014 +0000
update documentation for McpAcccountStorageIface members
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=e3748958037ac74bd6b89e6ea2439378e91b3b89
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Feb 5 13:24:45 2014 +0000
McdStorage: watch and proxy plugins' change-notification signals
This lets us get rid of the "ready" vfunc on plugins: we now
connect to each plugin's signals only after we have called
mcp_account_storage_list(), so we won't get double-notification for
accounts that are both present in the initial list and signalled.
This means we can remove a queue of delayed signal emissions from the
test D-Bus plugin (and when it's ported to this API, from Empathy's
libaccounts/UOA plugin). As far as I can see, list() and ready() happen
within the same main-loop iteration anyway, so I don't think it was
even possible to receive notification of a new account in that window.
Empathy's GNOME Online Accounts plugin never really implemented this:
in theory, it was incorrect, since any account that happened to be
added between list() and ready() would be lost altogether. However,
list() and ready() seem to happen in the same main-loop iteration,
so this might never have been a practical concern.
Rather than "fixing" Empathy's GOA plugin, it seems better to remove
the difficult case altogether.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=5090a5d462bfaa62300fa0526c043f60759306a6
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Feb 5 12:40:34 2014 +0000
McdAccountManager: if an account is async-added during setup, wait for it
Previously, we'd only wait for accounts added in mcd_storage_load()
to become ready.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=a48f28886f8417dcd10da01cb4e1330e59390119
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Feb 5 12:39:41 2014 +0000
McdAccountManager: ref the objects in McdLoadAccountsData
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=77e52ce80eb8705a039b7070515b89efb48863a5
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Feb 5 14:55:13 2014 +0000
mcd_keyfile_get_variant: add support for int16, uint16
If we're opportunistically migrating parameters according to
CM-specified types, we need to cope with uint16 ('q') for port numbers.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=0cfbd8ff018ce0387a6c517428cc1bd762d450b1
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Feb 5 14:48:12 2014 +0000
mcd_storage_maybe_migrate_parameters: fix error handling
mcp_account_storage_get_parameter() doesn't raise a GError.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=553acd80fac93fb21c28cb51f00c9c51045c9921
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Feb 4 14:15:32 2014 +0000
NEWS
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=9da576a7d1d6df02632f83e3d2613af1ab11fa17
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Feb 4 13:58:33 2014 +0000
Opportunistically migrate accounts from untyped to typed Parameters
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
[also depend on new tp-glib for
tp_connection_manager_param_dup_variant_type -smcv]
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=a9eb0c74c190d172cf3d47fa264ab5fb4a30ce62
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 16:59:41 2014 +0000
_mcd_account_reconnect: if the account isn't valid, just disconnect
It is not valid to call _mcd_account_connection_begin() unless the
account has a TpProtocol; in particular, if the account is "valid",
then we know it does have a TpProtocol.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=d3fa6dc5b7048f3461755bedb0e666f0d1f50108
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Feb 3 19:23:26 2014 +0000
_mcd_account_dup_parameters: try to get parameters' types from backend
Now that I've deleted ExternalAccountStorage support, we have two
uses for this function:
* get the parameters to be passed to RequestConnection
* get the parameters for our own D-Bus API (PropertiesChanged,
GetAll, etc.)
For the former, we should know the types already, because we should
already have a concrete CM/protocol in mind by the time we get here.
For the latter, ideally we shouldn't need the CM's types at all: if
the backend is storing parameters with types, it's arguably more
correct for Parameters to contain what the user stored, even if that
isn't an exact match for what the CM wants.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=33d38beed46dcc491759b70784b8a8c3b8c747e2
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Feb 3 20:24:57 2014 +0000
mcp_account_storage_get_flags: add
The initial flag is STORES_TYPES, which can be used to decide whether
to try to attach types to untyped parameters. Of our built-in plugins,
the default keyfile/variant-file storage and the D-Bus test plugin
have STORES_TYPES, but the "diversion" plugin does not.
Flags are account-specific in case they ever need to vary per-account
(e.g. a FROM_TELEPATHY_0 flag might be one way to deal with migration
from Telepathy 0.x to 1.0).
Also add some convenience API (has_all_flags, has_any_flag) to make
code that uses these flags easier to understand.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=7290f4e00a5eb3cd155998d7a0a81a14028ced7c
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Feb 3 20:22:32 2014 +0000
Require account plugins to provide the ability to list parameters
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=ea63753dbccb7fa617496c3c0d3d0d2bc0351bc3
Merge: 4bb5c7c c86536f
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Feb 3 16:38:31 2014 +0000
Merge branch 'telepathy-mission-control-5.16'
Conflicts:
src/Makefile.am
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=c86536f3b5fcc21eac60a836954d1aa002b67cc0
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 13:04:56 2014 +0000
codegen: avoid generating more than one thing in the same command
As with telepathy-glib commit 36c2a545c9, a rule like this:
_gen/x.c _gen/x.h: prerequisites
$(AM_V_GEN)x-generator
doesn't consider x.c and x.h together. Instead, it expands to two rules,
one to generate x.c and one to generate x.h, which happen to run the
same commands.
This means that in the worst case, you can end up running x-generator
twice in parallel, and they'll race with each other and overwrite or
delete each other's output.
Updated version of a patch from Ross Burton, taking into account that
we now generate a separate header for the gtk-doc. I use the gtk-doc
header as the one that "matters", because it's the last to be generated.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69446
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=4bb5c7c9dda80e1bbea9c37cd72268600e106abd
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 17:48:23 2014 +0000
mcd_account_check_validity, mcd_account_check_parameters: be synchronous
There isn't actually anything in these functions that needs to be async.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=0d6ef9401dfe24d3b8dd04e29196d64da6c22279
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 15:19:14 2014 +0000
Simplify the account connection pipeline, and make it private
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=4c539c002bb7c50aee24774edceb14495bdcc78e
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 15:14:52 2014 +0000
Squash mcd-account-connection.c into mcd-account.c
There's hardly anything there any more anyway.
Take the opportunity to replace _mcd_account_set_connection_context
and _mcd_account_get_connection_context with simple access to the
priv struct.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=d0c0da1d87363a6e823ec8749272d1746c0e2f16
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 15:13:15 2014 +0000
mcd_account_dup_protocol: factor out
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=7ca3067a53540caf20b752f7ceb76eeb5fcffc91
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 14:21:38 2014 +0000
mcd_account_get_parameter: take a TpConnectionManagerParam
We never call this function without a TpConnectionManagerParam readily
available - which is just as well, because it looks as though it would
crash if mcd_manager_get_protocol_param() failed.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=09e9800018d49f1d93cb8348e5f85c4fb916dc31
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 13:12:29 2014 +0000
Remove code-generation machinery
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69600
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=d1bae0ae839bea89f2797811b165150c9b6285ab
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 13:06:56 2014 +0000
Remove A.I.ExternalPasswordStorage, CM.I.AccountStorage
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33485
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=44512
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69600
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=8083503553ee039f7a203c9a5db00b61c0bda3a9
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 13:04:56 2014 +0000
codegen: avoid generating more than one thing in the same command
As with telepathy-glib commit 36c2a545c9, a rule like this:
_gen/x.c _gen/x.h: prerequisites
$(AM_V_GEN)x-generator
doesn't consider x.c and x.h together. Instead, it expands to two rules,
one to generate x.c and one to generate x.h, which happen to run the
same commands.
This means that in the worst case, you can end up running x-generator
twice in parallel, and they'll race with each other and overwrite or
delete each other's output.
Updated version of a patch from Ross Burton, taking into account that
we now generate a separate header for the gtk-doc. I use the gtk-doc
header as the one that "matters", because it's the last to be generated.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69446
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=79f0081b0a50ab59794827dd5af79f8671870fcd
Merge: 0e2b32c 0b2293f
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Jan 30 12:34:04 2014 +0000
Merge branch 'account-rework-27727-round4'
Reviewed-by: Xavier Claessens <xavier.claessens at collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=0b2293f16df6259d2f2aab1db1fc126c2edae59e
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Jan 28 17:36:33 2014 +0000
McpParameterFlags, McpAttributeFlags: move to the right header
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=775c27341c109cc4067df733ceec6c7728e9c6dd
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Jan 28 16:34:18 2014 +0000
Test that we add types to accounts' parameters when set
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=08ade738693e685d7de271792f605ebbc8af03df
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Jan 28 16:30:07 2014 +0000
McdAccountManagerDefault: opportunistically save parameters' types
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=70272b8fd90c65700bd0f6a8d7a4cc3849d42e21
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Jan 28 11:26:29 2014 +0000
Only exercise old avatar storage locations in 5-12 and 5-14 tests
Otherwise, it will reduce test coverage while porting to Telepathy 1.0:
all the tests dealing with old locations need to be disabled until we
implement 0.x -> 1.0 migration.
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=ed7bf646a77630de9e24641d5ca889904132fe85
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Jan 27 20:58:20 2014 +0000
Chop up the increasingly inaccurately-named default-keyring-storage test
This test hasn't dealt with a keyring for a while, and now only covers
"variant files". Split it into two: one deals with creating an account
at runtime in the default backend, and one deals with loading files
from disk.
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=3c32422dfcdcfcd16f106b7a5107cbe35be93e36
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Jan 27 20:16:33 2014 +0000
McdAccount: improve debug output for account validity
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=1beafc65f2125df00f89a8e47c7ac67a7be9fb9b
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Jan 27 20:16:21 2014 +0000
Add dedicated tests for keyfile-based storage
These are impossible to test without restarting Mission Control, because
we only read from one such location at a time; so there's no point in
trying to bundle them into one test.
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=c00effb16665ac09f3fa5bb781f2e65b0899f66b
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Jan 27 17:41:10 2014 +0000
Define MCP_API_VERSION_5_18, so implementations can use #ifdef
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=8010027de1f36e2151ec7fdb438cbe4144e51383
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Jan 27 17:38:56 2014 +0000
Make MCP_API_VERSION less misleading
We didn't release this in 5.15, so it'll be the 5.18 API instead.
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=37221c0f0955fe6afa33eba483d45e5204700c35
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Jan 27 17:25:55 2014 +0000
_mcd_account_manager_setup: simplify a loop
As per Xavier's review, we don't need to call
mcd_account_get_unique_name(), because account unique names (object path
tails) are the keys in this map anyway.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=c0b9663101092257873410d92e2c02219d109353
Author: Xavier Claessens <xavier.claessens at collabora.co.uk>
Date: Wed Nov 20 17:10:40 2013 -0500
Be consistent in the constness of arguments in storage virtual methods
We usually don't pass const objects
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=097db6919cc185342e6b3fed347ba15dae9d004d
Author: Xavier Claessens <xavier.claessens at collabora.co.uk>
Date: Wed Nov 20 16:06:35 2013 -0500
Remove MCP_ACCOUNT_STORAGE_PLUGIN_PRIO_KEYRING
I makes no sense now that MC stopped caring about secrets.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=e7ba5a86df4e90ec334a4c8ff9a11f9305458e00
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 17:34:58 2013 +0000
mcp_account_storage_commit: guarantee that we commit one at a time
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=9624c084d46660721aa0173e23103cd25165a5a5
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 17:33:28 2013 +0000
mcd_storage_commit: rely on never being called with account == NULL
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=8e5e39aa29a833be16598b2392539af07808a85d
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 17:33:06 2013 +0000
McdAccountManager: commit accounts one at a time
In the process, inline mcd_account_manager_write_conf_async
and uncork_storage_plugins into their callers, with considerable
simplification because the async API isn't actually used any more.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=762d3c7746146b7d94b3e3c5df7d78c62e78202f
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 16:49:04 2013 +0000
McdAccountManager: remove unused timed account storage commit
Nothing ever sets write_conf_id nonzero, so this can never be called
any more.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=28f6731e92a596eabea5c4975249d5927428f459
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 16:46:23 2013 +0000
delete_async: being asked to delete a nonexistent account is an error
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=183af896db254c19eedc62ad58d5e2b08297791f
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 16:31:47 2013 +0000
mcd_storage_delete_account: don't tolerate deletion of unknown accounts
We should always know what we're deleting, now.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=50247324010cbe6fb9495db71f1feccbc517cdea
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 16:31:21 2013 +0000
McdStorage: don't forget accounts until the McpAccountStorage says so
We shouldn't remove it from the hash table until the storage plugin
says ::deleted: until then, deletion could fail. This will become
significant when we start considering deletion of a deleted account to
be an error.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=ec5def2cdb05891f7d233a7039a1a94d2315040c
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 16:21:00 2013 +0000
McdAccount: don't delete from storage if already deleted
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=2f325de3b7847018071d13dd3d050b02c0832d9d
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 15:41:10 2013 +0000
deleted_cb: correct a debug message
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=9e890f2ee20791dc87093bb72b1a6a5148d28766
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 15:24:16 2013 +0000
McdAccountManagerDefault: get/set/commit on a missing account is an error
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=ff00f3cfcf3b50ad8fea903434b13f4dac33b793
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 15:20:26 2013 +0000
McdAccountManagerDefault: don't pass "absent" accounts up to MC
They're not really accounts, just gaps where an account could go.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=296a3ff2d5b0e5a6a2fbc0a577d98629b869e4cb
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 15:00:56 2013 +0000
McdAccountManagerDefault: track whether saving is needed correctly
_commit (self, am, "just/one/account") would reset the global "dirty"
flag, even if another account also needed writing out. I don't think
this could actually happen in practice, but it seems best to fix it.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=2257fbc2b95c00719aac0d8707643c05785dda4e
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 15:04:18 2013 +0000
McdAccountManagerDefault: don't try to save "absent" accounts
These are empty account records corresponding to empty files in a
high-priority directory, which only exist to "mask" an account
of the same name in a lower-priority directory.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=eb7dc4a25c602de15f87fc63f56610ba5a7a05f8
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:40:52 2013 +0000
dbus-account-plugin: fail tests on various invalid method calls
Methods that act on a single account should always be called on an
account that exists (if it doesn't, where did you get its name from?),
so treat it as an error if they are called with a nonexistent account.
commit() has a dual role here: the method that takes a non-NULL account
(which acts on a single account, as described), and the method that
takes a NULL account name (which is OK to call at any time, to commit
all of our 0-or-more accounts).
While we are not active, we don't claim to have any accounts at all,
so treat it as an error if any method is called with a non-NULL account
name while inactive.
I've temporarily made an exception for delete_async(), although that
exception is removed in a later patch on this branch. It's less bad
if delete_async() is called on an account that doesn't exist, because
if you do, the desired state ("account X doesn't exist") has already
been reached.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=1bdae99f8cd780caa7fdf3aa7f72ac7c853ef2a6
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:38:54 2013 +0000
dbus-account-plugin: fail tests if fake accounts service misbehaves
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=85b98a82332a55925b2bcc2f26bee530ee244dd7
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:22:28 2013 +0000
mcpa_unescape_variant_from_keyfile: inline implementation
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=2333321be2b6550a462d9cf92a1700d77d682734
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:21:45 2013 +0000
McdStorage: delete_cb: improve clarity with a temporary variable
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=3559e8dc58f847d58da2aa35ca4b7a18af8b93e1
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:20:44 2013 +0000
update_storage: re-indent
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=eabc50ba0c875f356adc2fc6f4008721309005ec
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:20:29 2013 +0000
mcd_storage_get_accounts: use (transfer none)
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=443a396b555635313f12163b0351f81fc63576ad
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:17:24 2013 +0000
mcd_storage_load: convert while loop into for loop
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=fb880af29636b7540116b865a122fa0757dd6ced
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:16:43 2013 +0000
created_cb: don't leak error
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=a58ba5a870d89f236ce529d2257e6a477ba4e876
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:14:45 2013 +0000
mc-debug-server: don't try to cope gracefully with a bad D-Bus connection
We know the regression tests are going to provide fake system and
session buses.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=f97f287ae9ad702a9300720b441c6cfc3915878a
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:14:16 2013 +0000
McpAccountStorage: more, and more informative, debug messages
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=026cbb87190680f53a9a3382ed65f6e31cd9a4e5
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 18:33:55 2014 +0000
fixup!
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=4a56a04f6860d7d66f25398c410a1c6435c9dca7
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:13:36 2013 +0000
mcp_account_storage_delete_async: be cancellable, at least in theory
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=812378a1064b35a54adb9dc992fe55ef7c5ddae5
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:12:53 2013 +0000
McpAccountStorage: update documentation for delete_async
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=5aa409ec88b30dbadaba799cff44d3ddd978a94e
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:02:13 2013 +0000
McpAccountStorage: override neither or both of delete_async, delete_finish
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=b95223939c82dbe7cd194a018e674c719f39de12
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Fri Nov 15 13:01:34 2013 +0000
McpAccountStorage: overriding get_* and list is mandatory
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=5ec39a1c88cf74a1e81d65de66f084ff8d467e48
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Nov 14 18:01:33 2013 +0000
McdAccountManager: ignore altered-one, deleted, toggled from wrong plugin
Now that the account knows its own storage plugin, this is pretty easy.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=5633f3ae27a762444bb7a487abfd1f4b2aeacbaf
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 18:28:53 2014 +0000
fixup!
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=d19d7d0998c872e9288c864b511c6297651498eb
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 14:34:12 2014 +0000
McdAccount: have a ref to the storage plugin from construct time onwards
This will make the account more self-contained.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=1e1ba5f4fef9ee83411d55e376f0f5fec0a6e892
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Nov 14 16:51:37 2013 +0000
McdStorage: when acting on one account, only store it in its plugin
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=03c99601d7a76fbc49ed376cd9c30ca631bc085f
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Nov 14 16:20:21 2013 +0000
mcp_account_storage_get: replace with get_attribute, get_parameter
The old API in which plugins poked new values into the McdStorage
was non-obvious, and also fundamentally incompatible with the idea
that each account is owned by at most one plugin: if an account
in a high-priority plugin is masked by one in a low-priority plugin,
the McdStorage can't prevent the low-priority plugin from changing
its effective attribute and parameter values.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=93b822857d1898caed819baad7680a10a23e0486
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Nov 14 16:29:02 2013 +0000
dbus-account-plugin: update internal cache correctly
The backend-makes-changes test replaces an typed parameter with an
untyped parameter. We correctly signalled the change to MC,
but didn't update the internal cache; the rather strange way in
which MC receives attributes/parameters masked this bug.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=ea1ebe93295eb140212a9b6885d7d2d9a613e6d1
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Nov 14 16:14:35 2013 +0000
mcp_account_manager_unescape_variant_from_keyfile: add
I want to push responsibility for unescaping into storage plugins.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=fcfe2c59cba3a8de7e4fe43b05723992cff25661
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Nov 14 16:12:17 2013 +0000
Thread expected GVariant types through to mcd_storage_get_*
We're going to need this soon, in order to advise plugins how best
to unescape the value. The result is still a GValue, for now.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=927db6c1644e8cc5843f0c7ff0a39b4f5736d152
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Nov 14 15:26:18 2013 +0000
mcp_account_storage_set_*: return whether anything changed
The plugins are better-placed to do this than McdStorage: they know
their own storage format, after all.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=cb5879dda2daedee866f1f516c952c33e4728560
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Nov 13 20:21:49 2013 +0000
McdStorage: remove "owns" method
We now know whose account it is, without having to do this.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=d06943578e345689f2d040dcc12cf314f64157b9
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Thu Nov 14 14:51:47 2013 +0000
Make mcp_account_storage_create() mandatory
This means we can (finally) track which plugin "owns" which account
in a reliable way.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=561206632852eb2cea78ec60dfeb10a88a53cd63
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Nov 13 19:44:46 2013 +0000
Make account deletion async (sort of), and imply a selective commit
This means we don't need to commit separately after each deletion,
and means account plugins don't have to have the concept of flagging
an account for "delete this later" - much rejoicing.
It also has the incidental benefit that we no longer use the C++
reserved word 'delete' in a header file.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=b1681efb1e541072bd23d70d2a25e2a521f2d271
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Nov 13 19:36:44 2013 +0000
Call set_attribute, set_parameter to delete them
It really doesn't make a great deal of sense to use the same callback
to delete individual keys, and to delete accounts.
McdAccountManagerDefault already dealt with that case, but
the two test plugins didn't.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=cae73ae1d7634b761f5121298359b6f45ebfbe25
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Nov 13 17:45:30 2013 +0000
McdAccountManager: don't double-delete accounts from storage
McdAccount (via mcd_account_delete_async) is responsible for deleting
itself from storage if necessary. McdAccountManager shouldn't
second-guess it.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=48dff5c37b468eaa927120093a6d872cba0265d7
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Nov 13 17:42:09 2013 +0000
Add some missing test coverage: IdentifyAccount failing hard
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=657b61379825143b83465c840e1fa70a66d3989f
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Nov 13 17:40:19 2013 +0000
McdStorage: adjust IdentifyAccount error behaviour
We were ignoring failures if they were NotImplemented or ServiceUnknown,
but thinking about it more, we should probably ignore "most" errors
here: the only errors that should abort the account-creation attempt
are those that indicate that the intended parameters are unusable,
namely InvalidArgument and InvalidHandle (in its secondary role as
"invalid identifier-that-corresponds-to-a-handle").
Also add more debug messages here.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=b69fcaca8a6c6d60c1106178d1285ef29466c189
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Nov 13 17:07:46 2013 +0000
mc-debug-server: don't exit when disconnected from system bus
The session bus is our fake system bus, too. We exit when libdbus tells
us we have disconnected, and ignore both the possible ways in which
GDBus can kill us, in order to get coverage stats.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=a3521e21d9534bb169c4d5361537656af3b06376
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 15:01:01 2014 +0000
fixup!
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=609bbcfa2ef5615839aafcc8b20734edb16dead6
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Nov 13 17:06:31 2013 +0000
mcd_account_delete: convert into mcd_account_delete_async
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=c1dfbed74b450b059bf9cac20a5b485c1656a66d
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Nov 13 15:56:34 2013 +0000
mcd_account_delete: be primarily responsible for emitting Removed
We still don't get here if disposed early, though.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=189f9a9e131bb113a88300228eb4cea5b135c9d9
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Nov 13 14:39:04 2013 +0000
mcd_storage_dup_attributes: remove
Nothing calls it, and getting rid of it is a step towards having
McdStorage just be a "view".
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=8e91d6b414c669f6397c7b7e5ba53b61aa30dbfd
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Nov 12 19:36:56 2013 +0000
mcp_account_manager_list_keys: remove
This is unused, and plugins don't have any good reason to call it.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=2dc61bd97a4e1d1862df5b45b0f28dfb1d8b2a2c
Author: Xavier Claessens <xavier.claessens at collabora.co.uk>
Date: Tue Nov 12 19:30:17 2013 +0000
Remove unused code
[adjusted to apply at a different position in the branch -smcv]
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=20b3a72a9a34b6c5eb095a24dc94d39f0bcf40ea
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Nov 12 18:13:24 2013 +0000
McpAccountStorage: have a default implementation for every method
Based on a patch by Xavier Claessens.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=8675bf5caaf33593e0e1b5c6cf30ff3133879fa2
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Nov 12 16:00:49 2013 +0000
mcp_account_storage_emit_created: fix doc-comment
Originally part of a commit by Xavier Claessens.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=65e376653dfea9d1b3712f8429b657f9d4338386
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Nov 12 16:00:31 2013 +0000
Remove mcp_account_storage_set()
_set_attribute() and _set_parameter() are now mandatory for writable
storage plugins.
Note that most of the keyfile escaping code is still needed to help
plugins to read their old keyfile values.
[adjusted to apply earlier in the branch; left in the code that
detects whether mcd_storage_set_parameter() is a no-op for an
escaped parameter; took out mcp_account_storage_emit_created
documentation fix -smcv]
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71384
Signed-off-by: Simon McVittie <simon.mcvittie at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=21ab80884868a065772297d31f8ce8ba0d30bb7b
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Nov 12 15:51:44 2013 +0000
McpAccountStorage: merge commit and commit_one into one function
Based on part of a patch by Xavier Claessens.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71384
Signed-off-by: Simon McVittie <simon.mcvittie at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=4db6783e78972a35a1f66ed0311cf8080a1b63e1
Author: Xavier Claessens <xavier.claessens at collabora.co.uk>
Date: Fri Nov 8 13:17:10 2013 -0500
Remove all notion of secret parameter
We now depend on SASLAuthentication for handling secret, and MC
does not have gnome-keyring anymore.
[Adjusted to apply before other storage API changes -smcv]
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71384
Signed-off-by: Simon McVittie <simon.mcvittie at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=0e2b32c64568c39a9bbcc556f5ee1a3cae811928
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 19:26:55 2014 +0000
insert telepathy-mission-control 5.16.1 entry in NEWS
We haven't had a 5.17.0 yet so we might as well.
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=f639eb12ac2ecb47688fad82291f93ccb312a4df
Merge: b65bca4 d4471cc
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 19:25:23 2014 +0000
Merge branch 'telepathy-mission-control-5.16'
Conflicts:
NEWS
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=d4471ccad3163ee33fe5b5bd5947ca47ad01158a
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 19:24:54 2014 +0000
NEWS
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=a4bcc16f16f72d7a2b8fe74e715183b7b6985427
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Jan 28 16:28:16 2014 +0000
mc-tool: fix setting automatic presence
We were using the wrong finish-function.
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74187
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=b65bca44d69815c55f388a1604a2406a4c3a89e8
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 14:12:42 2014 +0000
McdAccountManager: separate setup lock for AM from lock for new accounts
McdLoadAccountsData was being used for two separate things: either
the initial setup process for the AccountManager (not specific to an
account, blocking taking the AccountManager name) or the setup process
for an account being added by a storage plugin later on (specific to
an account, and hopefully after the AccountManager name has been taken).
Since release_load_accounts_lock() takes the AccountManager name in an
idempotent way, this happened to work most of the time. However,
if a storage plugin signals the addition of an account not in the
initial batch, and adding that account finishes before the setup
process for the initial batch, we'd take the name too early, and have
our D-Bus API before we should - that'd be bad.
Redo this so it makes more sense. We don't actually need a struct
for the "initial batch" case, because the McdAccountManager and maybe
a MigrateCtx is enough; just keep a count of locks in
McdAccountManagerPrivate.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74185
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=232c6e290bbb83418c63fb10a2d3412f6aa8b77d
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 14:21:21 2014 +0000
Comment that the first bus name we take is an initialization mutex
We need a mutex that will protect our account migration process
from other copies of MC running in parallel. If we don't take the
"main" name until later, then that name can't be our mutex.
Bug: related to https://bugs.freedesktop.org/show_bug.cgi?id=24000
Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=5f0da3297060d146bfa0573f7ebfa52fa9f4d975
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 13:37:17 2014 +0000
Update NEWS
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=9db8b4d408fcab826ea4a3146d0fef53472a577c
Merge: 37365d6 84f1f56
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Wed Jan 29 13:25:00 2014 +0000
Merge branch 'telepathy-mission-control-5.16'
Conflicts:
NEWS
configure.ac
src/mcd-account-manager-default.c
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=84f1f56a114738c622bcd926868f5c232b3e6d8c
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Tue Jan 28 11:08:33 2014 +0000
start 5.16.2
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=53f6d1cf3fecd6667591a43bf511518f5a4b345f
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Jan 27 14:51:36 2014 +0000
forgot a NEWS entry
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=4eb0184ff5c7020cfcbada0ee66e4336158fc49e
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date: Mon Jan 27 12:25:18 2014 +0000
5.16.1
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=4d107b2c4b2a5161b6e113fb60e283017b700255
Author: Michael Kuhn <suraia at ikkoku.de>
Date: Wed Jan 22 09:56:02 2014 +0100
Release inhibitor on sleep and shutdown.
Also fix a memory leak in login1_inhibit_cb.
[The intention was to hold one "ref" to the inhibit fd for each
connection that was waiting to disconnect, plus one "ref" for the
idle state of "waiting to be notified by logind". We correctly took
one "ref" per connection, but did not release the extra one. -smcv]
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=73599
Reviewed-by: Simon McVittie <simon.mcvittie at collabora.co.uk>
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=07955827bba3ed6a6426ca4f2cb32efef2dc04c0
Author: John Brooks <john.brooks at jollamobile.com>
Date: Thu Dec 12 15:46:27 2013 -0700
Prevent assert for offline accounts with power saving
Reviewed-by: Simon McVittie <simon.mcvittie at collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=72652
URL: http://cgit.freedesktop.org/telepathy/telepathy-mission-control/commit/?id=0932dba29fa9de8e7268a924c4c93ccebb7dc65c
Author: Sebastien Bacher <seb128 at ubuntu.com>
Date: Wed Dec 4 18:34:30 2013 +0100
reset the error to NULL, so the next call is working
[fixed argument type -smcv]
Reviewed-by: Simon McVittie <simon.mcvittie at collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=72138
More information about the telepathy-commits
mailing list